From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Eugen Hristev" <eugen.hristev@microchip.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Miaoqian Lin" <linmq006@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Paul Cercueil" <paul@crapouillou.net>,
"Mihail Chindris" <mihail.chindris@analog.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
chrome-platform@lists.linux.dev
Subject: Re: [RFT PATCH v3 10/10] iio: Don't silently expect attribute types
Date: Mon, 3 Oct 2022 12:42:05 +0300 [thread overview]
Message-ID: <YzqubeAnrH5FJ0vA@smile.fi.intel.com> (raw)
In-Reply-To: <b36ee317-abfe-9f55-70b5-bbf3138f50c0@gmail.com>
On Mon, Oct 03, 2022 at 11:58:35AM +0300, Matti Vaittinen wrote:
> On 10/3/22 11:43, Andy Shevchenko wrote:
> > On Mon, Oct 03, 2022 at 11:13:53AM +0300, Matti Vaittinen wrote:
...
> > > + for (i = 0, id_attr = buffer->attrs[i];
> > > + (id_attr = buffer->attrs[i]); i++)
> >
> > Not sure why we have additional parentheses...
>
> Because gcc warns about the assignment and suggests adding parenthesis if we
> don't.
Ah, this is a condition, so that's why compiler wants to have a _result_ of
the assignment and not the ambiguous thingy.
Btw, have you considered to switch to in-loop iterator definitions as we do
in many other places? Also, it might make sense to introduce for_each_...
type of macro helper if the loop is used more than once.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-03 9:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 8:09 [PATCH v3 00/10] iio: Fix unsafe buffer attributes Matti Vaittinen
2022-10-03 8:10 ` [PATCH v3 01/10] iio: adxl367: " Matti Vaittinen
2022-10-16 11:12 ` Jonathan Cameron
2022-10-03 8:10 ` [PATCH v3 02/10] iio: adxl372: " Matti Vaittinen
2022-10-16 11:12 ` Jonathan Cameron
2022-10-03 8:11 ` [PATCH v3 03/10] iio: bmc150-accel-core: " Matti Vaittinen
2022-10-16 11:13 ` Jonathan Cameron
2022-10-03 8:11 ` [PATCH v3 04/10] iio: at91-sama5d2_adc: " Matti Vaittinen
2022-10-06 8:34 ` Claudiu.Beznea
2022-10-16 11:14 ` Jonathan Cameron
2022-10-03 8:12 ` [PATCH v3 05/10] iio: Add IIO_STATIC_CONST_DEVICE_ATTR Matti Vaittinen
2022-10-03 8:12 ` [PATCH v3 06/10] iio: adxl367: Use IIO_STATIC_CONST_DEVICE_ATTR() Matti Vaittinen
2022-10-03 8:12 ` [PATCH v3 07/10] iio: adxl372: " Matti Vaittinen
2022-10-03 8:13 ` [PATCH v3 08/10] iio: bmc150-accel-core: " Matti Vaittinen
2022-10-03 8:13 ` [PATCH v3 09/10] iio: at91-sama5d2_adc: " Matti Vaittinen
2022-10-06 8:35 ` Claudiu.Beznea
2022-10-03 8:13 ` [RFT PATCH v3 10/10] iio: Don't silently expect attribute types Matti Vaittinen
2022-10-03 8:43 ` Andy Shevchenko
2022-10-03 8:58 ` Matti Vaittinen
2022-10-03 9:02 ` Matti Vaittinen
2022-10-03 9:39 ` Andy Shevchenko
2022-10-03 9:42 ` Andy Shevchenko [this message]
2022-10-06 8:35 ` Claudiu.Beznea
2022-10-06 12:53 ` Matti Vaittinen
2022-10-09 17:38 ` Jonathan Cameron
2022-10-10 9:36 ` Matti Vaittinen
2022-11-05 14:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzqubeAnrH5FJ0vA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.ardelean@analog.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=cosmin.tanislav@analog.com \
--cc=eugen.hristev@microchip.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mihail.chindris@analog.com \
--cc=miquel.raynal@bootlin.com \
--cc=nathan@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=paul@crapouillou.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox