public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: Ryan Huang <tzukui@google.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: Allow tuning tracing keys constant.
Date: Mon, 3 Oct 2022 15:44:31 -0400	[thread overview]
Message-ID: <Yzs7n48vRiE1+ASX@sashalap> (raw)
In-Reply-To: <5be617ad-0652-642f-aff8-7b7734f33973@redhat.com>

On Fri, Sep 30, 2022 at 01:34:24PM -0400, Waiman Long wrote:
>On 9/30/22 13:00, Ryan Huang wrote:
>>+config LOCKDEP_KEYS_BITS
>>+	int "Bitsize for MAX_LOCKDEP_KEYS"
>>+	depends on LOCKDEP && !LOCKDEP_SMALL
>>+	range 10 30
>>+	default 13
>>+	help
>>+	  Try increasing this value if you hit "BUG: MAX_LOCKDEP_KEYS too low!" message.
>>+
>>  config LOCKDEP_STACK_TRACE_BITS
>>  	int "Bitsize for MAX_STACK_TRACE_ENTRIES"
>>  	depends on LOCKDEP && !LOCKDEP_SMALL
>
>The lockdep key is embedded in a bit field within the held_lock 
>structure to utilize all the 32 bits of an integer. Changing its size 
>will require adjusting other bit fields or expand the bit field size 
>from 32 bits to 64 bits. 13 bits allows up to 8k unique lock classes. 
>Unless there is good evidence that we are going to run out of that, we 
>shouldn't change it.

Right, and this patch doesn't propose changing that (the value is
currently hardcoded to '13', and the config option defaults it to 13).

This change is about making it configurable.

-- 
Thanks,
Sasha

  reply	other threads:[~2022-10-03 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30 17:00 [PATCH] lockdep: Allow tuning tracing keys constant Ryan Huang
2022-09-30 17:34 ` Waiman Long
2022-10-03 19:44   ` Sasha Levin [this message]
2022-10-27 20:18   ` Ryan Huang
2022-10-01  2:30 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzs7n48vRiE1+ASX@sashalap \
    --to=sashal@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tzukui@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox