From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: alps: Simplify the .remove function
Date: Mon, 3 Oct 2022 17:40:39 +0200 [thread overview]
Message-ID: <YzsCdyPxrNcHE3XF@gmail.com> (raw)
In-Reply-To: <33cf94ec234b88ffc79eb4496c640093aa8c5e70.1664721476.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
Hi Christophe!
On Sun, Oct 02, 2022 at 04:38:26PM +0200, Christophe JAILLET wrote:
> If the .remove function of a 'hid_driver' is NULL, the default behavior is
> to call hid_hw_stop().
>
> So alps_remove() can be removed here, it is just hand-writing what
> already exists.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
There is already a patch out there :-)
https://lore.kernel.org/all/20220915123438.520775-1-marcus.folkesson@gmail.com/
Best regards,
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-03 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 14:38 [PATCH] HID: alps: Simplify the .remove function Christophe JAILLET
2022-10-03 15:40 ` Marcus Folkesson [this message]
2022-10-03 19:16 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzsCdyPxrNcHE3XF@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox