From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Prashant Malani <pmalani@chromium.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Cc: Daniel Scally <djrscally@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v3 1/5] device property: Allow const parameter to dev_fwnode()
Date: Tue, 4 Oct 2022 12:34:56 +0300 [thread overview]
Message-ID: <Yzv+QHCIs6ruWkXM@smile.fi.intel.com> (raw)
In-Reply-To: <20221004092129.19412-2-andriy.shevchenko@linux.intel.com>
On Tue, Oct 04, 2022 at 12:21:25PM +0300, Andy Shevchenko wrote:
> It's not fully correct to take a const parameter pointer to a struct
> and return a non-const pointer to a member of that struct.
>
> Instead, introduce a const version of the dev_fwnode() API which takes
> and returns const pointers and use it where it's applicable.
>
> With this, convert dev_fwnode() to be a macro wrapper on top of const
> and non-const APIs that chooses one based on the type.
Hmm... it missed the device_get_match_data() implementation (reverse) change
somehow. And it still compiles to me, probably I rebased wrongly and the hunk
went to another patch. I'll investigate and resend as v4 the fixed version.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-04 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 9:21 [PATCH v3 0/5] device property: Consitify a few APIs and Andy Shevchenko
2022-10-04 9:21 ` [PATCH v3 1/5] device property: Allow const parameter to dev_fwnode() Andy Shevchenko
2022-10-04 9:34 ` Andy Shevchenko [this message]
2022-10-04 9:38 ` Andy Shevchenko
2022-10-04 9:21 ` [PATCH v3 2/5] device property: Constify fwnode connection match APIs Andy Shevchenko
2022-10-04 9:21 ` [PATCH v3 3/5] device property: Constify parameter in fwnode_graph_is_endpoint() Andy Shevchenko
2022-10-04 9:21 ` [PATCH v3 4/5] device property: Constify device child node APIs Andy Shevchenko
2022-10-04 9:21 ` [PATCH v3 5/5] device property: Constify parameter in device_dma_supported() and device_get_dma_attr() Andy Shevchenko
2022-10-04 12:11 ` [PATCH v3 0/5] device property: Consitify a few APIs and Greg Kroah-Hartman
2022-10-22 11:50 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzv+QHCIs6ruWkXM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andersson@kernel.org \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox