Re: [PATCH v2 14/39] mm: Introduce VM_SHADOW_STACK for shadow stack memory

Edgecombe, Rick P
2022-10-04T00:29:34Z

On Mon, 2022-10-03 at 20:47 +0300, Kirill A . Shutemov wrote:
> > @@ -165,6 +165,8 @@ unsigned long get_mmap_base(int is_legacy)
> >
> > const char *arch_vma_name(struct vm_area_struct *vma)
> > {
> > + if (vma->vm_flags & VM_SHADOW_STACK)
> > + return "[shadow stack]";
> > return NULL;
> > }
> >
>
> But why here?
>
> CONFIG_ARCH_HAS_SHADOW_STACK implies that there will be more than one
> arch
> that supports shadow stack. The name has to come from generic code
> too, no?

I'm not aware of any other arch that will, so I wonder if I should just
remove ARCH_HAS_SHADOW_STACK actually.