Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack

Edgecombe, Rick P
2022-10-03T19:54:06Z

On Mon, 2022-10-03 at 16:40 +0300, Kirill A . Shutemov wrote:
> Hm. Shouldn't ARCH_HAS_SHADOW_STACK definition be in arch/Kconfig,
> not
> under arch/x86?
>
> Also, I think "def_bool n" has the same meaning as just "bool", no?
>
> > +
> > +config X86_SHADOW_STACK
> > + prompt "X86 Shadow Stack"
> > + def_bool n
>
> Maybe just
>
> bool "X86 Shadow Stack"
>
> ?
Yep, will change it. Thanks.