From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Kees Cook <keescook@chromium.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 1/2] minmax: sanity check constant bounds when clamping
Date: Tue, 4 Oct 2022 17:01:16 +0200 [thread overview]
Message-ID: <YzxKvMqO2WYD2gow@zx2c4.com> (raw)
In-Reply-To: <1DA96D23-12A0-4B5B-8032-90D13D4700E4@chromium.org>
On Tue, Oct 04, 2022 at 07:39:53AM -0700, Kees Cook wrote:
>
>
> On October 4, 2022 6:41:48 AM PDT, "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
> >On Mon, Sep 26, 2022 at 8:26 PM Kees Cook <keescook@chromium.org> wrote:
> >>
> >> On Mon, Sep 26, 2022 at 03:34:34PM +0200, Jason A. Donenfeld wrote:
> >> > The clamp family of functions only makes sense if hi>=lo. If hi and lo
> >> > are compile-time constants, then raise a build error. Doing so has
> >> > already caught buggy code. This also introduces the infrastructure to
> >> > improve the clamping function in subsequent commits.
> >> >
> >> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> > Cc: Andrew Morton <akpm@linux-foundation.org>
> >> > Cc: Kees Cook <keescook@chromium.org>
> >> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> >>
> >> Reviewed-by: Kees Cook <keescook@chromium.org>
> >
> >Wondering - did you ever queue this up for 6.1? I assume the plan is
> >to hold off on 2/2 for the time being, but this 1/2 is good to have
> >either way.
>
> Since it produced at least one warning, there may be others in weird
> archs/configs, so I wanted it to bake in -next after the merge window
> for 6.1 closes. It's a good feature, but I didn't want to risk new
> build warnings so close to the merge. :)
Alright, sounds good. Hope it catches more things!
Jason
next prev parent reply other threads:[~2022-10-04 15:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:06 [PATCH] minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld
2022-09-23 10:35 ` Andy Shevchenko
2022-09-23 10:40 ` Jason A. Donenfeld
2022-09-23 10:48 ` Jason A. Donenfeld
2022-09-23 15:12 ` Andy Shevchenko
2022-09-23 15:13 ` Jason A. Donenfeld
2022-09-23 15:40 ` [PATCH v2] " Jason A. Donenfeld
2022-09-23 16:41 ` Kees Cook
2022-09-23 16:42 ` Jason A. Donenfeld
2022-09-23 16:53 ` Andy Shevchenko
2022-09-23 16:54 ` Jason A. Donenfeld
2022-09-23 19:47 ` Kees Cook
2022-09-23 22:54 ` Andrew Morton
2022-09-24 0:02 ` Kees Cook
2022-09-24 10:37 ` Jason A. Donenfeld
2022-09-25 16:29 ` Andrew Morton
2022-09-26 10:00 ` Andy Shevchenko
2022-09-26 12:23 ` Jason A. Donenfeld
2022-09-26 13:34 ` [PATCH v3 1/2] minmax: sanity check constant bounds when clamping Jason A. Donenfeld
2022-09-26 13:34 ` [PATCH v3 2/2] minmax: clamp more efficiently by avoiding extra comparison Jason A. Donenfeld
2022-09-26 18:30 ` Kees Cook
2022-09-26 21:33 ` Jason A. Donenfeld
2022-09-26 13:46 ` [PATCH v3 1/2] minmax: sanity check constant bounds when clamping Andy Shevchenko
2022-09-26 18:26 ` Kees Cook
2022-10-04 13:41 ` Jason A. Donenfeld
2022-10-04 14:39 ` Kees Cook
2022-10-04 15:01 ` Jason A. Donenfeld [this message]
2022-09-26 18:30 ` [PATCH v2] minmax: clamp more efficiently by avoiding extra comparison Kees Cook
2022-09-23 15:10 ` [PATCH] " Andy Shevchenko
2022-09-23 15:11 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzxKvMqO2WYD2gow@zx2c4.com \
--to=jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox