Re: [PATCH net-next v3] net: ncsi: Fix GCPS 64-bit member variables

Paul Fertser
2025-04-11T11:23:04Z

Hello Hari,

On Thu, Apr 10, 2025 at 10:22:47AM -0700, kalavakunta.hari.prasad@gmail.com wrote:
> From: Hari Kalavakunta <kalavakunta.hari.prasad@gmail.com>
>
> Correct Get Controller Packet Statistics (GCPS) 64-bit wide member
> variables, as per DSP0222 v1.0.0 and forward specs. The Driver currently
> collects these stats, but they are yet to be exposed to the user.
> Therefore, no user impact.
>
> Statistics fixes:
> Total Bytes Received (byte range 28..35)
> Total Bytes Transmitted (byte range 36..43)
> Total Unicast Packets Received (byte range 44..51)
> Total Multicast Packets Received (byte range 52..59)
> Total Broadcast Packets Received (byte range 60..67)
> Total Unicast Packets Transmitted (byte range 68..75)
> Total Multicast Packets Transmitted (byte range 76..83)
> Total Broadcast Packets Transmitted (byte range 84..91)
> Valid Bytes Received (byte range 204..11)
>
> v2:
> - __be64 for all 64 bit GCPS counters
>
> v3:
> - be64_to_cpup() instead of be64_to_cpu()

Usually the changelog should go after --- so it's not included in the
final commit message when merged. I hope in this case the maintainers
will take care of this manually so no need to resend unless they ask
to.

Other than that,

Reviewed-by: Paul Fertser <fercerpav@gmail.com>

Thank you for working on this. I'll be looking forward to your next
patch where response validation is added.

BTW, have you already discussed how exactly you plan to expose the
statistics to the userspace, is that something that should end up
visible via e.g. `ethtool -S eth0 --groups nc-si` ?