From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C9C14AA9 for ; Wed, 16 Apr 2025 00:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744764814; cv=none; b=Ldt1zfVAzsc0NDnAFkECXrLTDSXPSNKzhmky3x+ri3rpTZUuUlYo/eVCYMh7IB8RQqOOpTUz4bamPJr86ibKr7B9TeEFLZg7e6fJEygq0T86bLINR0xFBVWARjhUCROV4WkjDmw7CDHPpTfDg/Y8svO4ACT2Vrj2tLeyeLklw60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744764814; c=relaxed/simple; bh=96B9PrXJW4G3rI3fvsK1uPWHxbv4fipG+KQ2mMcseBA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k/ZerQ+BCFS+9U6nGo0xn8wQ9phz4dq41d9PO7R/u1DkyE1sDpnJwROfBVf1yP9fcmUG6diiDHqPjQEwCpiEzKYfbtFNTlwlPz7kc1QNDnrC9b4QQQSMcT32fqYEDbpHBXDljNT9aKQODpOJNAyoGGfQfMk7l95WCAFK0WtqI9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=THPC0do/; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="THPC0do/" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-6feab7c5f96so59061867b3.3 for ; Tue, 15 Apr 2025 17:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1744764811; x=1745369611; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ls2b3PcDVLxYWfpvpeygqh0EYCIMqg9tqTsrdLj5Hpo=; b=THPC0do/jbA0gO42HIb3NlAVqfvmnFilceHccEEMxPn6ffKXiA3nAemGbWQQKOWvhm FL1ycjzYkh6eorktDG1dSSfp+Fz5ieU8B32Oe1IIp8l8UYfpLu7zMynjmdFhj1HzjmNj 1vigtdsRTmHGv+r2wJ5rq+UThJup1qwuUid89/8cQEvlBuMIWzBUM/5GYof7bfsBkSYR H68lf5iWtpmOQ5sCjIjmSWfRAYeACks7Nrz6CeL0876mWvkROcwHZG4+ZqVMfdbTRFzi cecs1Kmic0ZzE536ZzolBUraDgp88vWtHsaCvFzRuvkrzFDhzTLtQ3FEjBUH2J8kPSOa qSMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744764811; x=1745369611; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ls2b3PcDVLxYWfpvpeygqh0EYCIMqg9tqTsrdLj5Hpo=; b=ZSZg0PWNBD0zQ5LBvOzJ0+uhz0laMSdd301kfkS8DIkf5QUDvR8hPTPxvcAuOz5Zgg 388SxMd0ps5EQtjNjAHGeqvjq3zz1HHeXrpSwFKRT7as2N7sXc24fOqcZLjFXrgaOX6/ cXHjA0cpdQMlAxomlB0T9A0wz9s2Oa5CrSxIGsNlWLvX1asXc5wnMsK7X2IHQqhr0V++ yOzjX51WBRxW4FXlQ7TB7EfO/7y+UNSNOBknM2ZUzs/5D5gTrkreMHeu1KcCUmAP+QCf CWjs3KBxf1lhbM8rleXGD4SBvMIxxOmLsjxNp4m/lyxXKx7LYdJPjZxLBr7pzV5qCg4C 90IA== X-Forwarded-Encrypted: i=1; AJvYcCVf26OS2qaHl739NUdFY2uc3TwS/sZACyiWXTnYMTiuT6MaJHajLrwGABuqU6v2Cx51K0cJHRuRxP6RfUo=@vger.kernel.org X-Gm-Message-State: AOJu0YzwA+H6pZURxuWFO+wrCOH1idPWBIYty3PKCLyhXiSsFr9vc7O2 h1il4YkiLXVQ+pOnGbr8q2WzzYGZCD7Z9cRqAQglF//kR8afovlRt1+MVCNHrRh8DAPaZYaZjG2 71WkYhYF5UFZo5ThoDFjKsu9XHvVd8B0f X-Gm-Gg: ASbGncv0mJegmnmy9XHoeefnxG1sSKVJyobh3VIBr4HE4EqParjulAxNDEciyxA0Cfg P2TThSbx2QfEGLdjqqS7O6+oGfey463b+b8SqFZiISFwdd+frgUv8Aj50lZmbE5ueAGfLa0sEZp ukazyxF40ECt0HY18/X2/P8B8VoYexhlbFjYqJ5SxgZtOmXodWlOzNTtau/beaoONmRtjJBgZ+Y H4l66VIX6foho5eM1DeksmGtbAULDZRkEOC0SFO6Otmgi7bL35BOwakFLHlo8hvdMxDKKdIUVZC RDBCnTL6gU2qqbF5cqTTUEi5w/s7onYyKKsb/wSRajNOFA== X-Google-Smtp-Source: AGHT+IHa7i8bVol24qWunlXT4S3rE7nqfEbNrSA6OR95HlTd8daUtz+9iKquVi2+NvgJBKdtQkQEDGk6urqh X-Received: by 2002:a05:690c:4907:b0:6d4:4a0c:fcf0 with SMTP id 00721157ae682-706acede1aemr23383707b3.20.1744764811599; Tue, 15 Apr 2025 17:53:31 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.128]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-7053e171c20sm6472807b3.31.2025.04.15.17.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 17:53:31 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-ushankar.dev.purestorage.com (dev-ushankar.dev.purestorage.com [10.7.70.36]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id A6EBD340237; Tue, 15 Apr 2025 18:53:30 -0600 (MDT) Received: by dev-ushankar.dev.purestorage.com (Postfix, from userid 1557716368) id A3E47E41931; Tue, 15 Apr 2025 18:53:30 -0600 (MDT) Date: Tue, 15 Apr 2025 18:53:30 -0600 From: Uday Shankar To: Caleb Sander Mateos Cc: Jens Axboe , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ublk: don't suggest CONFIG_BLK_DEV_UBLK=Y Message-ID: References: <20250416004111.3242817-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250416004111.3242817-1-csander@purestorage.com> On Tue, Apr 15, 2025 at 06:41:10PM -0600, Caleb Sander Mateos wrote: > The CONFIG_BLK_DEV_UBLK help text suggests setting the config option to > Y so task_work_add() can be used to dispatch I/O, improving performance. > However, this mechanism was removed in commit 29dc5d06613f2 ("ublk: kill > queuing request by task_work_add"). So remove this paragraph from the > config help text. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Uday Shankar > --- > drivers/block/Kconfig | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > index 2551ebf88dda..e48b24be45ee 100644 > --- a/drivers/block/Kconfig > +++ b/drivers/block/Kconfig > @@ -386,16 +386,10 @@ config BLK_DEV_UBLK > io_uring based userspace block driver. Together with ublk server, ublk > has been working well, but interface with userspace or command data > definition isn't finalized yet, and might change according to future > requirement, so mark is as experimental now. > > - Say Y if you want to get better performance because task_work_add() > - can be used in IO path for replacing io_uring cmd, which will become > - shared between IO tasks and ubq daemon, meantime task_work_add() can > - can handle batch more effectively, but task_work_add() isn't exported > - for module, so ublk has to be built to kernel. > - > config BLKDEV_UBLK_LEGACY_OPCODES > bool "Support legacy command opcode" > depends on BLK_DEV_UBLK > default y > help > -- > 2.45.2 >