From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, rf@opensource.cirrus.com,
simont@opensource.cirrus.com, peterz@infradead.org,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp: Remove unnecessary NULL check before release_firmware()
Date: Mon, 7 Apr 2025 09:18:12 +0100 [thread overview]
Message-ID: <Z/OKRL+lFvav6rdp@opensource.cirrus.com> (raw)
In-Reply-To: <20250407063403.2772040-1-nichen@iscas.ac.cn>
On Mon, Apr 07, 2025 at 02:34:03PM +0800, Chen Ni wrote:
> release_firmware() checks for NULL pointers internally.
> Remove unneeded NULL check for fmw here.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2025-04-07 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 6:34 [PATCH] ASoC: wm_adsp: Remove unnecessary NULL check before release_firmware() Chen Ni
2025-04-07 8:18 ` Charles Keepax [this message]
2025-04-08 9:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/OKRL+lFvav6rdp@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peterz@infradead.org \
--cc=rf@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox