Re: [PATCH 1/4] dt-bindings: clock: ti: Convert to yaml

Sukrut Bellary
2025-04-09T07:46:52Z

On Fri, Apr 04, 2025 at 12:44:39PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Apr 03, 2025 at 06:44:57PM GMT, Sukrut Bellary wrote:
> > +properties:
> > + reg:
> > + maxItems: 1
>
> How reg is part of this? Every clock has reg, doesn't it? Otherwise how
> do you control it? Drop.

Thanks for the review.
I will drop.

> > +
> > + ti,autoidle-shift:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + bit shift of the autoidle enable bit for the clock
> > + maximum: 31
> > + default: 0
> > +
> > + ti,invert-autoidle-bit:
> > + type: boolean
> > + description:
> > + autoidle is enabled by setting the bit to 0
>
> required:
> - ti,autoidle-shift
> - ti,invert-autoidle-bit - although this makes no sense, so probably
> old binding was not correct here

Yes, all clocks don't support autoidle. So, required is not applicable
here.

> > +
> > +additionalProperties: true
> > +
> > +examples:
> > + - |
> > + bus {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + clock@1b4 {
> > + reg = <0x01b4>;
> > + ti,autoidle-shift = <8>;
> > + ti,invert-autoidle-bit;
> > + };
>
> Drop example, pointless here - noop due to lack of compatible. Instead
> provide complete examples in schemas referencing this.

Ok, will remove from here.

> > + };
> > --
> > 2.34.1
> >