Re: [PATCH 2/4] dt-bindings: clock: ti: Convert to yaml

Sukrut Bellary
2025-04-09T08:23:21Z

On Fri, Apr 04, 2025 at 12:46:28PM +0200, Krzysztof Kozlowski wrote:
> On Thu, Apr 03, 2025 at 06:44:58PM GMT, Sukrut Bellary wrote:
> > +maintainers:
> > + - Tero Kristo <kristo@kernel.org>
> > + - Sukrut Bellary <sbellary@baylibre.com>
> > +
> > +description: |
>
> Do not need '|' unless you need to preserve formatting.

Thanks for the review.
I will fix this.

> > + Every clock on TI SoC belongs to one clockdomain. For specific clocks, the
> > + parent clockdomain has to be controlled when the clock is enabled/disabled.
> > + This binding doesn't define a new clock binding type, it is used to group
> > + the existing clock nodes under hardware hierarchy.
> > +
> > +properties:
> > + compatible:
> > + const: ti,clockdomain
> > +
> > + clocks:
> > + description:
> > + Clocks within this domain
>
> Missing constraints.

I will add it.

> > +
> > +required:
> > + - compatible
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + l3init_clkdm: l3init_clkdm {
>
> Follow DTS coding style. Also drop unused label.
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Sure, will fix this.

> > + compatible = "ti,clockdomain";
> > + clocks = <&dpll_usb_ck>;
> > + };
> > --
> > 2.34.1
> >