linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Youngmin Nam <youngmin.nam@samsung.com>
To: Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Saravana Kannan <saravanak@google.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel-team@android.com,
	youngmin.nam@samsung.com, hajun.sung@samsung.com,
	d7271.choe@samsung.com, joonki.min@samsung.com
Subject: [GICv3 ITS]S2IDLE framework does not invoke syscore_ops in GICv3 ITS driver
Date: Wed, 26 Mar 2025 12:09:37 +0900	[thread overview]
Message-ID: <Z+Nv8U/4P3taDpUq@perf> (raw)
In-Reply-To: CGME20250326030527epcas2p33aa30e62cc8a00c9e151c35bee71dac5@epcas2p3.samsung.com

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

Hi.

On our SoC, we are using S2IDLE instead of S2R as a system suspend mode.
However, when I try to enable ARM GICv3 ITS driver (drivers/irqchip/irq-gic-v3-its.c),
I noticed that there is no proper way to invoke suspend/resume callback,
because it only uses syscore_ops, which is not called in an s2idle scenario.
Please refer to the codes below.

<drivers/irqchip/irq-gic-v3-its.c>
5028 static struct syscore_ops its_syscore_ops = {
5029         .suspend = its_save_disable,
5030         .resume = its_restore_enable,
5031 };
...
5803         register_syscore_ops(&its_syscore_ops);

<kernel/power/suspend.c>
444         if (state == PM_SUSPEND_TO_IDLE) {
445                 s2idle_loop();
446                 goto Platform_wake;
447         }
448
449         error = pm_sleep_disable_secondary_cpus();
450         if (error || suspend_test(TEST_CPUS)) {
451                 log_suspend_abort_reason("Disabling non-boot cpus failed");
452                 goto Enable_cpus;
453         }
454
455         arch_suspend_disable_irqs();
456         BUG_ON(!irqs_disabled());
457
458         system_state = SYSTEM_SUSPEND;
459
460         error = syscore_suspend();

How should we handle this situation ?

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



       reply	other threads:[~2025-03-26  3:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250326030527epcas2p33aa30e62cc8a00c9e151c35bee71dac5@epcas2p3.samsung.com>
2025-03-26  3:09 ` Youngmin Nam [this message]
2025-03-26  8:59   ` [GICv3 ITS]S2IDLE framework does not invoke syscore_ops in GICv3 ITS driver Marc Zyngier
2025-03-27  3:22     ` Youngmin Nam
2025-03-27  8:25       ` Marc Zyngier
2025-03-28  2:10         ` Youngmin Nam
2025-04-01 12:45         ` Ulf Hansson
2025-04-01 13:11           ` Marc Zyngier
2025-04-02 10:57             ` Ulf Hansson
2025-04-03  7:16               ` Marc Zyngier
2025-04-02 11:56       ` Sudeep Holla
2025-04-03  1:30         ` Youngmin Nam
2025-04-03  9:18           ` Sudeep Holla
2025-04-04  4:13             ` Donghyeok Choe
2025-04-07  9:17               ` Sudeep Holla
2025-04-07 22:51                 ` Donghyeok Choe
2025-04-08  6:51                   ` Marc Zyngier
     [not found]                     ` <CGME20250408223026epcas2p220582f5c0401b442921cda2571c595ec@epcas2p2.samsung.com>
2025-04-08 22:28                       ` Donghyeok Choe
2025-04-08 10:46                   ` Sudeep Holla
     [not found]                     ` <CGME20250408221326epcas2p24b455e5a9f65dff52807a3a0010eff9a@epcas2p2.samsung.com>
2025-04-08 22:11                       ` Donghyeok Choe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z+Nv8U/4P3taDpUq@perf \
    --to=youngmin.nam@samsung.com \
    --cc=d7271.choe@samsung.com \
    --cc=hajun.sung@samsung.com \
    --cc=joonki.min@samsung.com \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=saravanak@google.com \
    --cc=tglx@linutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).