Re: [PATCH v2 1/2] dt-bindings: mailbox: add cix,sky1-mbox

[Guomin chen <guomin.chen@cixtech.com>]

On Fri, Mar 28, 2025 at 08:12:58AM +0100, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On 28/03/2025 04:13, Guomin chen wrote:
> >>> +> +  cix,mbox-dir:
> >>> +    $ref: /schemas/types.yaml#/definitions/uint32
> >>> +    description: Direction of the mailbox (0:TX or 1:RX)
> >>> +    enum: [0, 1]
> >>
> >> Respond to comments or implement them. Previous discussion was not
> >> resolved - you did not respond. Sending the same with unfinished
> >> discussion is not way to convince maintainer. Opposite: you will get
> >> NAKed because you try to finish discussion and push your patch over the
> >> wall.
> >>
> > Sorry, about your previous comments.
> >
> > As previously mentioned, each Cixtech mailbox controller is unidirectional.
> > Each mailbox supports 11 channels, which differ only in their transmission
> > methods (e.g., FIFO, REG, doorbell). However, the transmission direction of
> > all channels within the same mailbox is fixed and determined by the mailbox
> > controller itself.
> >
> > The Sky1 SoC contains 4 pairs (8 total) mailbox controllers. To identify
> > whether a controller is TX or RX relative to the AP, the driver introduces
> > the 'mbox-dir' property in DTS.
> 
> OK, that's fine, but as pointed in example - use strings 'rx' and 'tx',
> not numbers.
> 
thank you for your suggestion. 
I will use the strings 'rx' and 'tx' instead of numbers.

Best regards,
Guomin Chen