From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mika Westerberg <westeri@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 4/5] gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
Date: Thu, 3 Apr 2025 14:04:04 +0300 [thread overview]
Message-ID: <Z-5rJDWaSJd58lTa@smile.fi.intel.com> (raw)
In-Reply-To: <20250403103506.GJ3152277@black.fi.intel.com>
On Thu, Apr 03, 2025 at 01:35:06PM +0300, Mika Westerberg wrote:
> On Wed, Apr 02, 2025 at 03:21:19PM +0300, Andy Shevchenko wrote:
> > Some of the contents of struct acpi_gpio_lookup repeats what we have
> > in the struct acpi_gpio_params. Reuse the latter in the former.
> > + struct acpi_gpio_params par;
>
> params is better name
It's been already used elsewhere in the code. Do you want renaming there as
well for consistency's sake?
...
> > struct acpi_gpio_lookup *lookup = data;
> > + struct acpi_gpio_params *par = &lookup->par;
>
> These are not changed I guess so can this be const?
They are, see below. So the answer, it can't.
But I will double check and add const where it makes sense.
...
> > if (lookup->info.quirks & ACPI_GPIO_QUIRK_ONLY_GPIOIO && gpioint)
> > - lookup->index++;
> > + par->crs_entry_index++;
E.g., ^^^
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-03 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 12:21 [PATCH v1 0/5] gpiolib: acpi: Refactor to shrink the code by ~8% Andy Shevchenko
2025-04-02 12:21 ` [PATCH v1 1/5] gpiolib: acpi: Improve struct acpi_gpio_info memory footprint Andy Shevchenko
2025-04-02 12:21 ` [PATCH v1 2/5] gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup() Andy Shevchenko
2025-04-02 12:21 ` [PATCH v1 3/5] gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params Andy Shevchenko
2025-04-02 12:21 ` [PATCH v1 4/5] gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup Andy Shevchenko
2025-04-03 10:35 ` Mika Westerberg
2025-04-03 11:04 ` Andy Shevchenko [this message]
2025-04-03 11:57 ` Bartosz Golaszewski
2025-04-03 12:12 ` Andy Shevchenko
2025-04-03 12:38 ` Mika Westerberg
2025-04-02 12:21 ` [PATCH v1 5/5] gpiolib: acpi: Deduplicate some code in __acpi_find_gpio() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-5rJDWaSJd58lTa@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox