The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH -tip v2] x86/idle: Work around LLVM assembler bug with MONITOR and MWAIT insn
Date: Thu, 3 Apr 2025 13:20:33 +0200	[thread overview]
Message-ID: <Z-5vAThgDL9gts35@gmail.com> (raw)
In-Reply-To: <20250403091737.344149-1-ubizjak@gmail.com>


* Uros Bizjak <ubizjak@gmail.com> wrote:

> LLVM assembler is not able to assemble correct forms of MONITOR
> and MWAIT instructions with explicit operands:
> 
>   error: invalid operand for instruction
>           monitor %rax,%ecx,%edx
>                        ^~~~
> 
> Use instruction mnemonics with implicit operands to
> work around this issue.
> 
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Fixes: cd3b85b27542 ("x86/idle: Use MONITOR and MWAIT mnemonics in <asm/mwait.h>")
> Reported-by: kernel test robot <lkp@intel.com>

So I've zapped cd3b85b27542 instead - let's re-try it again and
see if there's any code generation tradeoffs vs. the byte encodings?

Thanks,

	Ingo

  reply	other threads:[~2025-04-03 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  9:17 [PATCH -tip v2] x86/idle: Work around LLVM assembler bug with MONITOR and MWAIT insn Uros Bizjak
2025-04-03 11:20 ` Ingo Molnar [this message]
2025-04-03 11:25   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-5vAThgDL9gts35@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=tglx@linutronix.de \
    --cc=ubizjak@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox