public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: Johan Hovold <johan+linaro@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>,
	Stephan Gerhold <stephan.gerhold@linaro.org>,
	ath12k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath12k: extend dma mask to 36 bits
Date: Mon, 24 Mar 2025 10:18:33 +0100	[thread overview]
Message-ID: <Z-EjaQ70mtQwQsgs@hovoldconsulting.com> (raw)
In-Reply-To: <0e2060ec-f0ed-41dc-8325-0ec839a59dd5@quicinc.com>

On Mon, Mar 24, 2025 at 04:33:13PM +0800, Baochen Qiang wrote:
> On 3/22/2025 12:23 AM, Johan Hovold wrote:
> > Extend the DMA mask to 36 bits to avoid using bounce buffers on machines
> > without an iommu (under OS control) similar to what was done for ath11k
> > in commit dbd73acb22d8 ("wifi: ath11k: enable 36 bit mask for stream
> > DMA").
> > 
> > This specifically avoids using bounce buffers on Qualcomm Snapdragon X
> > Elite machines like the Lenovo ThinkPad T14s when running at EL1.
> > 
> > Note that the mask could possibly be extended further but unresolved DMA
> > issues with 64 GiB X Elite machines currently prevents that from being
> > tested.
> > 
> > Also note that the driver is limited to 32 bits for coherent
> > allocations and that there is no need to check for errors when setting
> > masks larger than 32 bits.
> > 
> > Tested-on: WCN7850 hw2.0 WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

> Reviewed-by: Baochen Qiang <quic_bqiang@quicinc.com>
> 
> With WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 this is working, so:
> 
> Tested-by: Baochen Qiang <quic_bqiang@quicinc.com>

Thanks for reviewing and testing.

Johan

  reply	other threads:[~2025-03-24  9:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 16:23 [PATCH] wifi: ath12k: extend dma mask to 36 bits Johan Hovold
2025-03-24  3:06 ` Baochen Qiang
2025-03-24  7:40   ` Johan Hovold
2025-03-24  8:05     ` Baochen Qiang
2025-03-24  8:20       ` Johan Hovold
2025-03-24  8:29         ` Baochen Qiang
2025-03-24  8:33 ` Baochen Qiang
2025-03-24  9:18   ` Johan Hovold [this message]
     [not found] ` <b1e44988-a80c-4e60-a093-434e0834aa1a@quicinc.com>
2025-03-26  4:29   ` Vasanthakumar Thiagarajan
2025-03-26 15:11 ` Jeff Johnson
2025-03-26 15:16   ` Johan Hovold
2025-03-26 15:41     ` Jeff Johnson
2025-03-27 22:58 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-EjaQ70mtQwQsgs@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=jjohnson@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_bqiang@quicinc.com \
    --cc=stephan.gerhold@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox