Re: [PATCH net-next v5 6/6] net: usb: lan78xx: remove unused struct members

Russell King (Oracle)
2025-03-24T16:20:41Z

On Wed, Mar 19, 2025 at 09:49:52AM +0100, Oleksij Rempel wrote:
> Remove unused members from struct lan78xx_net, including:
>
> driver_priv
> suspend_count
> link_on
> mdix_ctrl
> interface
> fc_autoneg
> fc_request_control
>
> These fields are no longer used in the driver and can be safely removed
> as part of a cleanup.

Shouldn't these members be removed in the patches that removed their
users? For example, I think "interface" becomes unused in patch 2.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!