From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: mailhol.vincent@wanadoo.fr
Cc: Yury Norov <yury.norov@gmail.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Andi Shyti <andi.shyti@linux.intel.com>,
David Laight <David.Laight@aculab.com>,
Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v7 2/5] bits: introduce fixed-type BIT_U*()
Date: Mon, 24 Mar 2025 15:41:49 +0200 [thread overview]
Message-ID: <Z-FhHRWtaYgTbILa@smile.fi.intel.com> (raw)
In-Reply-To: <20250322-fixed-type-genmasks-v7-2-da380ff1c5b9@wanadoo.fr>
On Sat, Mar 22, 2025 at 06:23:13PM +0900, Vincent Mailhol via B4 Relay wrote:
> From: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Implement fixed-type BIT_U*() to help drivers add stricter checks,
> like it was done for GENMASK_U*().
...
> +/*
> + * Fixed-type variants of BIT(), with additional checks like GENMASK_TYPE(). The
> + * following examples generate compiler warnings due to shift-count-overflow:
"...due to -Wshift-count-overflow:" ?
Same idea — if you need a new version, since it's just a nit-pick.
> + *
> + * - BIT_U8(8)
> + * - BIT_U32(-1)
> + * - BIT_U32(40)
> + */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-24 13:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 9:23 [PATCH v7 0/5] bits: Fixed-type GENMASK_U*() and BIT_U*() Vincent Mailhol via B4 Relay
2025-03-22 9:23 ` [PATCH v7 1/5] bits: introduce fixed-type GENMASK_U*() Vincent Mailhol via B4 Relay
2025-03-24 7:22 ` Andy Shevchenko
2025-03-24 7:44 ` Vincent Mailhol
2025-03-22 9:23 ` [PATCH v7 2/5] bits: introduce fixed-type BIT_U*() Vincent Mailhol via B4 Relay
2025-03-24 13:41 ` Andy Shevchenko [this message]
2025-03-24 14:16 ` Vincent Mailhol
2025-03-24 14:32 ` Andy Shevchenko
2025-03-22 9:23 ` [PATCH v7 3/5] drm/i915: Convert REG_GENMASK*() to fixed-width GENMASK_U*() Vincent Mailhol via B4 Relay
2025-03-22 9:23 ` [PATCH v7 4/5] test_bits: add tests for GENMASK_U*() Vincent Mailhol via B4 Relay
2025-03-22 9:23 ` [PATCH v7 5/5] test_bits: add tests for BIT_U*() Vincent Mailhol via B4 Relay
2025-03-24 14:28 ` [PATCH v7 0/5] bits: Fixed-type GENMASK_U*() and BIT_U*() Yury Norov
2025-03-24 16:23 ` Vincent Mailhol
2025-03-25 15:23 ` Yury Norov
2025-03-25 16:13 ` Vincent Mailhol
2025-03-25 16:30 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-FhHRWtaYgTbILa@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lucas.demarchi@intel.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox