public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	the arch/x86 maintainers <x86@kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [GIT PULL] x86/build updates for v6.15
Date: Tue, 25 Mar 2025 07:44:17 +0100	[thread overview]
Message-ID: <Z-JQwWSdyVXkttUI@gmail.com> (raw)
In-Reply-To: <CAHk-=whu2fb22rEy6+oKx1-+NCHuWucZepvD0H2MD38DrJVKtg@mail.gmail.com>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sat, 22 Mar 2025 at 04:46, Ingo Molnar <mingo@kernel.org> wrote:
> >
> >  - Drop CRC-32 checksum and the build tool that generates it
> >    (Ard Biesheuvel)
> 
> Hmm. I didn't notice this during the merge process, but not too long
> afterwards it became obvious that this caused problems.
> 
> I've committed the fix separately: commit 2df0c02dab82 ("x86 boot
> build: make git ignore stale 'tools' directory").

Thank you!

> Please don't just mindlessly remove .gitignore entries for generated 
> files.
> 
> Because even if *you* may have removed the file, the generated files 
> don't magically disappear from everybody else, and when the gitignore 
> entry is gone, you are now setting other developers up for mistakes.

Indeed. I never saw this warning, as the directory was gone, but on a 
build box I have:

  Untracked files:
  ...
	arch/x86/boot/tools/

And I can see how this can then be added back in spuriously.

Thanks,

	Ingo

      reply	other threads:[~2025-03-25  6:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-22 11:46 [GIT PULL] x86/build updates for v6.15 Ingo Molnar
2025-03-25  6:08 ` pr-tracker-bot
2025-03-25  6:27 ` Linus Torvalds
2025-03-25  6:44   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-JQwWSdyVXkttUI@gmail.com \
    --to=mingo@kernel.org \
    --cc=ardb@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox