public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] x86/build updates for v6.15
@ 2025-03-22 11:46 Ingo Molnar
  2025-03-25  6:08 ` pr-tracker-bot
  2025-03-25  6:27 ` Linus Torvalds
  0 siblings, 2 replies; 4+ messages in thread
From: Ingo Molnar @ 2025-03-22 11:46 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-kernel, the arch/x86 maintainers, Ard Biesheuvel,
	Peter Zijlstra, H. Peter Anvin

Linus,

Please pull the latest x86/build Git tree from:

   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-build-2025-03-22

   # HEAD: e471a86a8c523eccdfd1c4745ed7ac7cbdcc1f3f x86/boot: Add back some padding for the CRC-32 checksum

x86/build updates for v6.15:

 - Drop CRC-32 checksum and the build tool that generates it
   (Ard Biesheuvel)

 - Fix broken copy command in genimage.sh when making isoimage
   (Nir Lichtman)

 Thanks,

	Ingo

------------------>
Ard Biesheuvel (2):
      x86/boot: Drop CRC-32 checksum and the build tool that generates it
      x86/boot: Add back some padding for the CRC-32 checksum

Nir Lichtman (1):
      x86/build: Fix broken copy command in genimage.sh when making isoimage


 Documentation/arch/x86/boot.rst        |  10 --
 arch/x86/boot/Makefile                 |   7 +-
 arch/x86/boot/compressed/vmlinux.lds.S |   2 +-
 arch/x86/boot/genimage.sh              |   5 +-
 arch/x86/boot/setup.ld                 |   2 +
 arch/x86/boot/tools/.gitignore         |   2 -
 arch/x86/boot/tools/build.c            | 247 ---------------------------------
 7 files changed, 9 insertions(+), 266 deletions(-)
 delete mode 100644 arch/x86/boot/tools/.gitignore
 delete mode 100644 arch/x86/boot/tools/build.c

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] x86/build updates for v6.15
  2025-03-22 11:46 [GIT PULL] x86/build updates for v6.15 Ingo Molnar
@ 2025-03-25  6:08 ` pr-tracker-bot
  2025-03-25  6:27 ` Linus Torvalds
  1 sibling, 0 replies; 4+ messages in thread
From: pr-tracker-bot @ 2025-03-25  6:08 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Linus Torvalds, linux-kernel, the arch/x86 maintainers,
	Ard Biesheuvel, Peter Zijlstra, H. Peter Anvin

The pull request you sent on Sat, 22 Mar 2025 12:46:09 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-build-2025-03-22

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ebfb94d87b35a4b5fc6fda0cf994268555ebe415

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] x86/build updates for v6.15
  2025-03-22 11:46 [GIT PULL] x86/build updates for v6.15 Ingo Molnar
  2025-03-25  6:08 ` pr-tracker-bot
@ 2025-03-25  6:27 ` Linus Torvalds
  2025-03-25  6:44   ` Ingo Molnar
  1 sibling, 1 reply; 4+ messages in thread
From: Linus Torvalds @ 2025-03-25  6:27 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: linux-kernel, the arch/x86 maintainers, Ard Biesheuvel,
	Peter Zijlstra, H. Peter Anvin

On Sat, 22 Mar 2025 at 04:46, Ingo Molnar <mingo@kernel.org> wrote:
>
>  - Drop CRC-32 checksum and the build tool that generates it
>    (Ard Biesheuvel)

Hmm. I didn't notice this during the merge process, but not too long
afterwards it became obvious that this caused problems.

I've committed the fix separately: commit 2df0c02dab82 ("x86 boot
build: make git ignore stale 'tools' directory").

Please don't just mindlessly remove .gitignore entries for generated files.

Because even if *you* may have removed the file, the generated files
don't magically disappear from everybody else, and when the gitignore
entry is gone, you are now setting other developers up for mistakes.

                 Linus

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL] x86/build updates for v6.15
  2025-03-25  6:27 ` Linus Torvalds
@ 2025-03-25  6:44   ` Ingo Molnar
  0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2025-03-25  6:44 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-kernel, the arch/x86 maintainers, Ard Biesheuvel,
	Peter Zijlstra, H. Peter Anvin


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sat, 22 Mar 2025 at 04:46, Ingo Molnar <mingo@kernel.org> wrote:
> >
> >  - Drop CRC-32 checksum and the build tool that generates it
> >    (Ard Biesheuvel)
> 
> Hmm. I didn't notice this during the merge process, but not too long
> afterwards it became obvious that this caused problems.
> 
> I've committed the fix separately: commit 2df0c02dab82 ("x86 boot
> build: make git ignore stale 'tools' directory").

Thank you!

> Please don't just mindlessly remove .gitignore entries for generated 
> files.
> 
> Because even if *you* may have removed the file, the generated files 
> don't magically disappear from everybody else, and when the gitignore 
> entry is gone, you are now setting other developers up for mistakes.

Indeed. I never saw this warning, as the directory was gone, but on a 
build box I have:

  Untracked files:
  ...
	arch/x86/boot/tools/

And I can see how this can then be added back in spuriously.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-25  6:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-22 11:46 [GIT PULL] x86/build updates for v6.15 Ingo Molnar
2025-03-25  6:08 ` pr-tracker-bot
2025-03-25  6:27 ` Linus Torvalds
2025-03-25  6:44   ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox