From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0985A93D for ; Tue, 25 Mar 2025 06:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742885067; cv=none; b=BxPOJn8IknPovY09FMJmBWcTVZ6uVQLL9srqyhI6Cg4FChXAZ9pJTqzG3u978xeWBuvITP05wUdFVr8ThTHQdhwr8X2OrF9htUfilFTbVj8Zomu7y2wd4AK/X66g3ILGIDS0KCNljYxnP4LTXhzs5zq2rqR7meCd7KIb37SR9BY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742885067; c=relaxed/simple; bh=6ROCD3uVkDG8LybE3EunVRNDwRVemcB1Qg9wRiVuOBw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YG2IS0gh4j/z9CalumHX5AwM1cR579TvuLpFGa/13RweX/RkQJobnE5KQr2Xjv2aRvIAGgkhDNYmSneUxwk5i6qYHzd5JQdAHGMu9UgCWETGss6EtV6DIeHZDT+MAzMyUlA4LcVARhpdiAgtb26oyXsHGxUoeB/OQJSe3TZd14s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LaWU+VBy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LaWU+VBy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EE12C4CEE8; Tue, 25 Mar 2025 06:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742885067; bh=6ROCD3uVkDG8LybE3EunVRNDwRVemcB1Qg9wRiVuOBw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LaWU+VByYj2gx9zQ8lMpNrOnO04UgR1XTny9KBoxRmNp57OGugJBziRipFghudshY sEGPSqy9laI+xp2dqoJ26d5xY/hVKyqUnCsTcQQNa1ryJC0LnS1ARgbaDIS5c/ksiF jWi+jLkv7oOec51gQvAvGJic4jHh6jkG4Hv4DaG4qG0K0+HIiRb2d9jdl8oizhR+Xv nXnWGSn51dbvPs4B4qKLKcrU59qHlWX5tst0H1Va5f7wKrMllzJgQtoUC80krUc1O9 Lb7Yy6bY1iHjIO7oDd/t8Yh8PIFctJA6Zv+uujtFxzQS5EHY/QCFxIiju1KrCuBk+T B0apUqvNYgB9w== Date: Tue, 25 Mar 2025 07:44:17 +0100 From: Ingo Molnar To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, the arch/x86 maintainers , Ard Biesheuvel , Peter Zijlstra , "H. Peter Anvin" Subject: Re: [GIT PULL] x86/build updates for v6.15 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Linus Torvalds wrote: > On Sat, 22 Mar 2025 at 04:46, Ingo Molnar wrote: > > > > - Drop CRC-32 checksum and the build tool that generates it > > (Ard Biesheuvel) > > Hmm. I didn't notice this during the merge process, but not too long > afterwards it became obvious that this caused problems. > > I've committed the fix separately: commit 2df0c02dab82 ("x86 boot > build: make git ignore stale 'tools' directory"). Thank you! > Please don't just mindlessly remove .gitignore entries for generated > files. > > Because even if *you* may have removed the file, the generated files > don't magically disappear from everybody else, and when the gitignore > entry is gone, you are now setting other developers up for mistakes. Indeed. I never saw this warning, as the directory was gone, but on a build box I have: Untracked files: ... arch/x86/boot/tools/ And I can see how this can then be added back in spuriously. Thanks, Ingo