From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CACC2258CC8 for ; Tue, 25 Mar 2025 13:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742908974; cv=none; b=sSQ0eQ5PDgk5DbgYVZUkccJBqClWvU4+nUv0wu0bOuQtbz7jnxRp74dePZrdwlCALpyGW+4sEPQ/lkibHyKuqDEC7Lq/RRDhjh1RXWoNOPATIkUrGFFMYANPDTrdWVP4Lv6ixT6aepsinRiR+F/cvrBsjsyz0PaT1NuNT1sFihw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742908974; c=relaxed/simple; bh=7QuLXuwPU1pYcM+fDNimsvk8TLkug4Ij6zG11JZYuNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HRylqbdosrLS0rjECn49c0Iw9s+f3a1FkwGfr2JdDZnwOLM+K36lkX4PibY7KE3lRcmsSqW0K05avdhQgHkiVUmzesELq/b2KOD3LGkBfjwn9KafI0Dca8K0rwAf195rQeN+4jpUAQcl1a+GvUNRs638SpJHTEmwZSP1olyZPPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IC4Mmj89; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IC4Mmj89" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-39727fe912cso2020654f8f.3 for ; Tue, 25 Mar 2025 06:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742908970; x=1743513770; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LlGiVNk8Yt0jmLDGPVZqC17dJyZ1FtuKp/XxOfDeIWc=; b=IC4Mmj89tk/5/c2aQ67Zaj0DogDfc5O1jD33f2nk2ctjsAGvWmKuLo+Xl3SjlZJYdi ul37ypv5FBla/69XdbCeBtMbSD4te8leQ1Ci8UkF/A9iQxA+MhiDFh7dgj17OEupGqoq mfOHQtvOP1H85nZ15KIflZdNmshaAq0Hf/PB9JHQaBLeGBsbGJhV3TCU51EfGTkTg9Gc QAz+phnR/vhAKGblZxvv6C7SFVXBdPPlayaksoHsxoLsouJq8zu0onNJ312CxNQb38xt CUmJwe6XkA1lQa52Ca9awafDxTys01pCLE4nuoylLjKOWD/ng60TiOwWucAyAOBYA/iH aC/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742908970; x=1743513770; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LlGiVNk8Yt0jmLDGPVZqC17dJyZ1FtuKp/XxOfDeIWc=; b=EeIsvWdoTrrukmJ/FH44lW4RuTplzJLoM8fcW6YPtyNBuyDrm9YNf3fkL15DuUeYMk LRV4vljJzo0npXyNnh4R1hsuiTmKWcX+w+v2PCFgSF7k/d6G6slPeK8CzQoMcvxCBmxw +yhqlaqMEXGO9esaKG6rMIp1+cx3HZjudNiIj/kDw1pCPNce4kL4bBcblFEvtF3Zl+Kz +7Au9juGWpwoNY8jHCBk095TLurl/C+ES1CKhvNG5jzgAWNcnogGQjQPBkHZkFyg1dG+ 7DHCZq27RwzUlfQKjfVUSy4xRUgpa6exz9yU7P6cZLiAUKneKvEiwoBcspLYEWO+CCD9 anyQ== X-Forwarded-Encrypted: i=1; AJvYcCXajlKQ5SAIYJplFtP/ArMjGGFOq6S8/gBY3BlYJ4pZf+Vhla7gmHjVknbDeVKOjCC7MBqnEEbW4/EUhwg=@vger.kernel.org X-Gm-Message-State: AOJu0YzfYSTX9frpuf6AMwz5EwAxhLdt9miz7efck5/sZ+YUHfDkfHoo iLHTFhtjV1SY5yVc05WsZSViaiCQeyoEMM5F9pK3/KstFdPzQGrPIyphemNfh4M= X-Gm-Gg: ASbGncu1YQB3A9fxJ49nloh9gzmtrSGU01aUYWXe7Fl5+LRO4S/7CTQ45ZqaoIyeIAZ L7pbuyFe2j5iOoqxYW8uoPj5O5cHo+AJ+Spxq9iGKwy3H8gfuPmSi65lf7n6HZXktgbxOyOpewq wMpzy3+H2hJzjJVeLUWdkqjyBOZ/Sl+zrAPo9XZrx36UdNGUeTWY8FqVFiR6iVZjE4xQUFISwgA q8yed+/UkFepPAdczr8aA1o2WHUow8jDL57N0xarJdwDPOhg0JFgwwZq5PLMlM5Lh2kDobq6kzU 2jIxIi/QFKSovN6Fa4XUr0c5g1RN3zw4AzaA96ZXPQOr4PCwVu6XRzfe X-Google-Smtp-Source: AGHT+IF5ByOpPrTa4U4GRV56ywaOSjVp6h6VrRCWNkmgB0f1xyrCpfKj9/gzFmkeDgA9BwrCjSe/wA== X-Received: by 2002:a05:6000:1ac8:b0:390:f6aa:4e80 with SMTP id ffacd0b85a97d-3997f937b82mr16939893f8f.53.1742908969958; Tue, 25 Mar 2025 06:22:49 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:1f3c:c5ac:d437:69b5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9efd61sm13902105f8f.91.2025.03.25.06.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 06:22:49 -0700 (PDT) Date: Tue, 25 Mar 2025 14:22:45 +0100 From: Stephan Gerhold To: Abel Vesa Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Johan Hovold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: x1e001de-devkit: Add Wi-Fi and Bluetooth pwrseq Message-ID: References: <20250324-x1e001de-devkit-dts-pwrseq-v1-1-530f69b39a16@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250324-x1e001de-devkit-dts-pwrseq-v1-1-530f69b39a16@linaro.org> On Mon, Mar 24, 2025 at 04:24:01PM +0200, Abel Vesa wrote: > The Qualcomm X Elite Devkit comes with a WCN7850 combo chip which provides > Wi-fi and Bluetooth, similar to the CRD and QCP. > > Describe the nodes for the Wi-Fi, Bluetooth, the related regulators and > the PMU. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 144 +++++++++++++++++++++++++++ > 1 file changed, 144 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > index 74911861a3bf2606add8cf4aaa3816542e837513..8f288a138c4cb6e21725fdf726eb2a2489bfbc38 100644 > --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > @@ -17,6 +17,7 @@ / { > > aliases { > serial0 = &uart21; > + serial1 = &uart14; > }; > > wcd938x: audio-codec { > @@ -392,6 +393,42 @@ vph_pwr: regulator-vph-pwr { > regulator-boot-on; > }; > > + vreg_wcn_0p95: regulator-wcn-0p95 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_WCN_0P95"; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <950000>; > + > + vin-supply = <&vreg_wcn_3p3>; > + }; > + > + vreg_wcn_1p9: regulator-wcn-1p9 { > + compatible = "regulator-fixed"; > + > + regulator-name = "VREG_WCN_1P9"; > + regulator-min-microvolt = <1900000>; > + regulator-max-microvolt = <1900000>; > + > + vin-supply = <&vreg_wcn_3p3>; > + }; Hm, on CRD and T14s there is a TODO comment above these two, which is also why I haven't posted these upstream yet: We still haven't come to a conclusion unfortunately how to model the M.2 WiFi/BT cards. QCP doesn't have M.2, which is why it is upstream already. These two regulators don't actually exist on the devkit itself, they are (probably) part of the M.2 card. The devkit only provides the 3.3V and 1.8V supply to the M.2 card. We should really find some way forward for this, but just omitting any mention of this is not the best way. :-) Thanks, Stephan