Re: [PATCH net-next v5 1/6] net: usb: lan78xx: Improve error handling in PHY initialization

Russell King (Oracle)
2025-03-24T15:31:36Z

On Wed, Mar 19, 2025 at 09:49:47AM +0100, Oleksij Rempel wrote:
> } else {
> if (!phydev->drv) {
> netdev_err(dev->net, "no PHY driver found\n");
> - return NULL;
> + return ERR_PTR(-EINVAL);
> }

Idly wondering why this driver cares whether the PHY has a driver or
not (it seemingly wants to exclude the generic driver.) Not a reason
to reject the patch, just curious.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!