From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29F36190696 for ; Tue, 25 Mar 2025 22:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742943328; cv=none; b=CjvGWPY65HtHQf7K913aFXWXscRpxVAizYXfhasWTzhD+S1SjLqQZ1/CWeMJ6OQSRFqAWgaWhoFgS/pJBAi2JIsolhx88koP/VjOnmbmmq07DTqph8WzHWyGJgIkrdUx79fyPbezTGYEfhz7LuNIXsoDgwkh73Hs6lZ/vqoedfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742943328; c=relaxed/simple; bh=3ATsKOEl3U55Kx0tNiQbYgKWXpTx+lq0HaAgp3b+/1I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NCg3By51f12OoE/EPi8qwgZI+dnyuneB6LmGfKhvm4X83qmjHwYjGi/fGhZrGH2YEaYqPiR8Tm3C1nZxbGFZeq8NhJw3B2Xofnr8OnEn1Av19IsDWoHSmp7odVAL1BkFBBujZhdBynl+GQK8SiKq0OvxTgJ70hsV+bhUzwVISFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZyczogLj; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZyczogLj" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2ff797f8f1bso10406087a91.3 for ; Tue, 25 Mar 2025 15:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1742943326; x=1743548126; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/rWYTl0BQ8sV08+fAcHai9+yEEk78TAqV1oXCWKXLvo=; b=ZyczogLjhc45iJvvJluP48PgYwXfI4ElqHvn7tUwgjL2KzxYgZFDYRAAlmIMmjrf01 JAUiUEPqh+U9uJ8Rr1U8euA7CCF5c4G4E9/VhKCEMFh5sBV3GD88k6T+YdDkGTap5G0q AMzI5VBrx+gzWie6CXsY1QYFXJ/L5IfEgLUz0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742943326; x=1743548126; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/rWYTl0BQ8sV08+fAcHai9+yEEk78TAqV1oXCWKXLvo=; b=VkWjS9eE3h7Xnsh8cSZacY6JH1IXVF1my4WhulL64bNLoUgSKdHkSJk+C9iTMqnmkd hGq64lToQ6H+/3pNXIDtaO6u8ylw7/T2X4Zxc2hm2voXFSEqHYNBWZrjb7HvgQa4Pymj bwBdGs+bDMuKl+MkdssypbUwaClWXr4CoPt93jVTf7jG+OkH1KU1XobGasMDZMI5IOIM 66ESpO1xzEN1uPLcKJe92wZTT9ZtVBN/fcnOQzRQsh1WAZPWjcKFeJ5UaZACv6tUDIt1 omLE38C9eVwkcPfxPsG3w/8PqlENm41xAGKus6JuHo+agVCBrX/Zx8YBUGOv6TWixf05 qoUQ== X-Forwarded-Encrypted: i=1; AJvYcCUCby6zFxo62hD7uhDB1YVm5okGP89j6ZHu1hsLNcYLyy50UWwi2Ds+/Uk2u8jX+0ijmYj9BZ3gOHn6CMk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0/SOX060QwLt3Btu+NXn4701TevkuQlwe3p4zn0WCcyX/03Qb bEhmEbmaL0mYoyUU9efmK4V3I/Sl4Ohxd7W3/qNNqfjgMob5PiBejUHjrgzWaw== X-Gm-Gg: ASbGncsX+sRZb6xxoc1bXAHLyEqFcc52DAtoapn6/CrN3w943ePbYvMN72ZCg7rGxY0 rUZfbJXPU2SJ22CMF2Hp5PE/rOxmBS6uDsrljDpij3LNrtnwcFcRrG31frNHCt4qImc63S7jiH0 KMsJWSjfqX+VpFxqfrj83ZoQgCObSfdVFryU5emrUT2CPMRzQAEuAmPCkAMxC+hlB9+5pOiNTL8 kDm7z/1PBC1OM+OlG3QiSwdDgMTG1CSdZhoHXYQ9/vyYfQrzp0U37lFzG+gfyGDYi1RyVE3HLYn ImGLLmsStUY+UPjDZRWqwGPV3hj283WeVrC/TayJkRKOCAm+DYsJqTxrSg3GxmnkggxBZVjuKb/ nE9hUKu8= X-Google-Smtp-Source: AGHT+IG9S6QnIRAL+Dp97HJUJGLI8iqjec4PoLgiksev72cNRulybhcRcYYBIlaatzFFYS67MgI4+w== X-Received: by 2002:a17:90b:390a:b0:2ee:bc7b:9237 with SMTP id 98e67ed59e1d1-3030fef0a26mr27364715a91.27.1742943326173; Tue, 25 Mar 2025 15:55:26 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:b885:47c3:6268:77fb]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-3030f60994dsm10989539a91.26.2025.03.25.15.55.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Mar 2025 15:55:25 -0700 (PDT) Date: Tue, 25 Mar 2025 15:55:23 -0700 From: Brian Norris To: Johannes Berg Cc: Jeff Chen , Francesco Dolcini , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pete Hsieh , "s.hauer@pengutronix.de" Subject: Re: [EXT] Re: [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF calibration data. Message-ID: References: <20250220061143.1417420-2-jeff.chen_1@nxp.com> <20250318050739.2239376-2-jeff.chen_1@nxp.com> <20250319162842.GA46894@francesco-nb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 25, 2025 at 05:45:10PM +0100, Johannes Berg wrote: > On Tue, 2025-03-25 at 16:43 +0000, Jeff Chen wrote: > > > > > > I have decided to withdraw the patch. I appreciate your feedback and attention to detail, > > which helped identify this oversight. > > > > This goes for _everyone_ on this thread... I applied this patch a long > time ago. Whatever you need to fix, you need to send new patches. If it needs withdrawn, I suppose Jeff should send a revert patch then. > And I guess next time I'm not going to apply any patches for mwifiex > however innocent they look ... thus making the situation of that driver > even worse than it is now. > > So please get together and form a plan on how to maintain it. My 2 cents: * Technically, I'm listed as maintainer still. I'm not always prompt, but I try to eventually get around to stuff (or at least see that Francesco reviews). I believe the previous implicit agreement would be that the wireless-drivers maintainer would wait for an Ack from sub-maintainer(s) before applying, unless they were truly trivial. I don't require that, of course, if you'd like to take things on your own Johannes, but that was my previous understanding. * I'm also used to seeing email replies when patches get applied. Kalle used to do that (presumably from some kind of push-time automation?), but I see you don't. You're of course free to do this however works best for you, but I find such emails useful for all interested parties (authors, reviewers, etc.). For example, if I thought the patches were controversial and were on my ToDo list, I'd probably speak up sooner. Brian