* [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu_dfl()
@ 2025-03-26 20:12 Tejun Heo
2025-03-26 20:21 ` Andrea Righi
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2025-03-26 20:12 UTC (permalink / raw)
To: David Vernet, Andrea Righi, Changwoo Min; +Cc: linux-kernel
scx_select_cpu_dfl() has a meaningless conditional goto at the end. Remove
it. No functional changes.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Andrea Righi <arighi@nvidia.com>
---
Applied to sched_ext/for-6.15-fixes. Thanks.
kernel/sched/ext_idle.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
index 45061b584380..b5f451e616d4 100644
--- a/kernel/sched/ext_idle.c
+++ b/kernel/sched/ext_idle.c
@@ -584,8 +584,6 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64
* increasing distance.
*/
cpu = scx_pick_idle_cpu(p->cpus_ptr, node, flags);
- if (cpu >= 0)
- goto out_unlock;
out_unlock:
rcu_read_unlock();
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu_dfl()
2025-03-26 20:12 [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu_dfl() Tejun Heo
@ 2025-03-26 20:21 ` Andrea Righi
0 siblings, 0 replies; 2+ messages in thread
From: Andrea Righi @ 2025-03-26 20:21 UTC (permalink / raw)
To: Tejun Heo; +Cc: David Vernet, Changwoo Min, linux-kernel
On Wed, Mar 26, 2025 at 10:12:11AM -1000, Tejun Heo wrote:
> scx_select_cpu_dfl() has a meaningless conditional goto at the end. Remove
> it. No functional changes.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Andrea Righi <arighi@nvidia.com>
Looks good, thanks!
Acked-by: Andrea Righi <arighi@nvidia.com>
-Andrea
> ---
> Applied to sched_ext/for-6.15-fixes. Thanks.
>
> kernel/sched/ext_idle.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
> index 45061b584380..b5f451e616d4 100644
> --- a/kernel/sched/ext_idle.c
> +++ b/kernel/sched/ext_idle.c
> @@ -584,8 +584,6 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64
> * increasing distance.
> */
> cpu = scx_pick_idle_cpu(p->cpus_ptr, node, flags);
> - if (cpu >= 0)
> - goto out_unlock;
>
> out_unlock:
> rcu_read_unlock();
> --
> 2.48.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-26 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-26 20:12 [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu_dfl() Tejun Heo
2025-03-26 20:21 ` Andrea Righi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox