From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu_dfl()
Date: Wed, 26 Mar 2025 21:21:04 +0100 [thread overview]
Message-ID: <Z-RhsP84IcMyLodA@gpd3> (raw)
In-Reply-To: <Z-Rfm5MVdm5rDyYC@slm.duckdns.org>
On Wed, Mar 26, 2025 at 10:12:11AM -1000, Tejun Heo wrote:
> scx_select_cpu_dfl() has a meaningless conditional goto at the end. Remove
> it. No functional changes.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Andrea Righi <arighi@nvidia.com>
Looks good, thanks!
Acked-by: Andrea Righi <arighi@nvidia.com>
-Andrea
> ---
> Applied to sched_ext/for-6.15-fixes. Thanks.
>
> kernel/sched/ext_idle.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
> index 45061b584380..b5f451e616d4 100644
> --- a/kernel/sched/ext_idle.c
> +++ b/kernel/sched/ext_idle.c
> @@ -584,8 +584,6 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64
> * increasing distance.
> */
> cpu = scx_pick_idle_cpu(p->cpus_ptr, node, flags);
> - if (cpu >= 0)
> - goto out_unlock;
>
> out_unlock:
> rcu_read_unlock();
> --
> 2.48.1
>
prev parent reply other threads:[~2025-03-26 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 20:12 [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu_dfl() Tejun Heo
2025-03-26 20:21 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-RhsP84IcMyLodA@gpd3 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox