The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jake Hillion <jake@hillion.co.uk>
Cc: arighi@nvidia.com, changwoo@igalia.com, sched-ext@meta.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: create_dsq: Return -EEXIST on duplicate request
Date: Wed, 26 Mar 2025 10:33:01 -1000	[thread overview]
Message-ID: <Z-RkfScRAanAPs79@slm.duckdns.org> (raw)
In-Reply-To: <20250325224041.14088-1-jake@hillion.co.uk>

On Tue, Mar 25, 2025 at 10:41:52PM +0000, Jake Hillion wrote:
> create_dsq and therefore the scx_bpf_create_dsq kfunc currently silently
> ignore duplicate entries. As a sched_ext scheduler is creating each DSQ
> for a different purpose this is surprising behaviour.
> 
> Replace rhashtable_insert_fast which ignores duplicates with
> rhashtable_lookup_insert_fast that reports duplicates (though doesn't
> return their value). The rest of the code is structured correctly and
> this now returns -EEXIST.
> 
> Tested by adding an extra scx_bpf_create_dsq to scx_simple. Previously
> this was ignored, now init fails with a -17 code. Also ran scx_lavd
> which continued to work well.
> 
> Signed-off-by: Jake Hillion <jake@hillion.co.uk>

Applied to sched_ext/for-6.15-fixes w/ stable cc'd.

Thanks.

-- 
tejun

      parent reply	other threads:[~2025-03-26 20:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 22:41 [PATCH] sched_ext: create_dsq: Return -EEXIST on duplicate request Jake Hillion
2025-03-26  6:08 ` Andrea Righi
2025-03-26 20:33 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-RkfScRAanAPs79@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=jake@hillion.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox