From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched_ext: initialize built-in idle state before ops.init()
Date: Wed, 26 Mar 2025 10:49:29 -1000 [thread overview]
Message-ID: <Z-RoWbLDwgqGYvtq@slm.duckdns.org> (raw)
In-Reply-To: <20250325093212.47188-1-arighi@nvidia.com>
On Tue, Mar 25, 2025 at 10:32:12AM +0100, Andrea Righi wrote:
> A BPF scheduler may want to use the built-in idle cpumasks in ops.init()
> before the scheduler is fully initialized, either directly or through a
> BPF timer for example.
>
> However, this would result in an error, since the idle state has not
> been properly initialized yet.
>
> This can be easily verified by modifying scx_simple to call
> scx_bpf_get_idle_cpumask() in ops.init():
>
> $ sudo scx_simple
>
> DEBUG DUMP
> ===========================================================================
>
> scx_simple[121] triggered exit kind 1024:
> runtime error (built-in idle tracking is disabled)
> ...
>
> Fix this by properly initializing the idle state before ops.init() is
> called. With this change applied:
>
> $ sudo scx_simple
> local=2 global=0
> local=19 global=11
> local=23 global=11
> ...
>
> Fixes: d73249f88743d ("sched_ext: idle: Make idle static keys private")
> Signed-off-by: Andrea Righi <arighi@nvidia.com>
Applied to sched_ext/for-6.15-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2025-03-26 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 9:32 [PATCH v2] sched_ext: initialize built-in idle state before ops.init() Andrea Righi
2025-03-25 15:19 ` Joel Fernandes
2025-03-26 20:49 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-RoWbLDwgqGYvtq@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox