From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH 0/2] Clear AMD's microcode cache on load failure
Date: Fri, 28 Mar 2025 14:53:06 +0100 [thread overview]
Message-ID: <Z-apwoVEQkwCH-Y2@gmail.com> (raw)
In-Reply-To: <20250328134544.GAZ-aoCA03g9SygDnW@fat_crate.local>
* Borislav Petkov <bp@alien8.de> wrote:
> On Fri, Mar 28, 2025 at 02:36:14PM +0100, Ingo Molnar wrote:
> > It would be a pretty common usecase to attempt to load the earlier
> > version if the loading of a new one doesn't succeed, right?
>
> This is only for late loading and no one should do that anyway.
>
> And load failure almost never happens - unless you're a cloud guy doing
> special hackery.
>
> So no need to expedite this as a fix - the majority does not care.
Well, it's a regression over previous behavior, so it is a regression
fix for an upstream change that is only a few weeks old, and it's an
overall quality-of-life fix for those users that are affected. There's
no exception to the expected upstreaming of regression fixes just
because there's few users affected.
Given how simple the fix looks, and how fresh the recent big microcode
loading changes are to begin with, I think we should apply it to
x86/urgent and then (maybe) it can be forwarded to -stable in a few
weeks if there's no problems. (Or not.)
Ie. my main point is that delaying it to v6.16 is not justified IMHO.
Thanks,
Ingo
next prev parent reply other threads:[~2025-03-28 13:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 21:03 [PATCH 0/2] Clear AMD's microcode cache on load failure Boris Ostrovsky
2025-03-27 21:03 ` [PATCH 1/2] x86/microcode/AMD: Fix __apply_microcode_amd()'s return value Boris Ostrovsky
2025-03-27 21:03 ` [PATCH 2/2] x86/microcode/AMD: Clean the cache if update did not load microcode Boris Ostrovsky
2025-03-27 21:33 ` [PATCH 0/2] Clear AMD's microcode cache on load failure Ingo Molnar
2025-03-27 21:44 ` boris.ostrovsky
2025-03-27 23:40 ` Borislav Petkov
2025-03-28 13:36 ` Ingo Molnar
2025-03-28 13:45 ` Borislav Petkov
2025-03-28 13:53 ` Ingo Molnar [this message]
2025-03-28 14:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-apwoVEQkwCH-Y2@gmail.com \
--to=mingo@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox