From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 756BF3597B; Sat, 29 Mar 2025 09:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743242256; cv=none; b=fm2946D+1sFtbBu7yWzZ0Xg0XZZjUPqYg0uodvQ2R62f+DKZTG6jkiWfNiair3G/Q8TMomZllv/tlnrkCOxzAWakNH9p2dQCt/1vASy3oD01eb243w+0nAZ1CVtA6FpMxVp/J3gVpnqkEeaggA9mPuvSLUM8rtgeDdD1rmiWUaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743242256; c=relaxed/simple; bh=n56iBYJh+619jz44wL6s7DUA0CbNuuQMnW5pkyXaauk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aq8m9lGZbPTSvJQlzjQuSC2zLAy1NxmHyK8qEG40NwjHvT07nlq+1uNMXvV7jlE1EbEyPUUGqAoh1cOWZNMCEhLRZSyfb67Ze9QAtC34QOahwJ4jvd2X9LDKLu5G/hwmL5TnEym8H+DArsMH9wMWV8aR0g4U77AVLMQOFiKNvmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1tySwO-0005VP-00; Sat, 29 Mar 2025 10:57:24 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id BB183C00F0; Sat, 29 Mar 2025 10:57:15 +0100 (CET) Date: Sat, 29 Mar 2025 10:57:15 +0100 From: Thomas Bogendoerfer To: Khem Raj Cc: Masahiro Yamada , Nicolas Schier , Kees Cook , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mips: Add '-std=gnu11' to vdso CFLAGS Message-ID: References: <20250327032436.3600578-1-raj.khem@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250327032436.3600578-1-raj.khem@gmail.com> On Wed, Mar 26, 2025 at 08:24:36PM -0700, Khem Raj wrote: > GCC 15 changed the default C standard dialect from gnu17 to gnu23, > which should not have impacted the kernel because it explicitly requests > the gnu11 standard in the main Makefile. However, mips/vdso code uses > its own CFLAGS without a '-std=' value, which break with this dialect > change because of the kernel's own definitions of bool, false, and true > conflicting with the C23 reserved keywords. > > include/linux/stddef.h:11:9: error: cannot use keyword 'false' as enumeration constant > 11 | false = 0, > | ^~~~~ > include/linux/stddef.h:11:9: note: 'false' is a keyword with '-std=c23' onwards > include/linux/types.h:35:33: error: 'bool' cannot be defined via 'typedef' > 35 | typedef _Bool bool; > | ^~~~ > include/linux/types.h:35:33: note: 'bool' is a keyword with '-std=c23' onwards > > Add '-std=gnu11' to the decompressor and purgatory CFLAGS to eliminate > these errors and make the C standard version of these areas match the > rest of the kernel. please adapt subject and description. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]