From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
acopo Mondi <jacopo+renesas@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: rdacm2x: Make use of device properties
Date: Mon, 31 Mar 2025 15:23:21 +0300 [thread overview]
Message-ID: <Z-qJOeeHUgWCtkTv@smile.fi.intel.com> (raw)
In-Reply-To: <20250331120748.GB28722@pendragon.ideasonboard.com>
On Mon, Mar 31, 2025 at 03:07:48PM +0300, Laurent Pinchart wrote:
> On Mon, Mar 31, 2025 at 09:16:36AM +0100, Kieran Bingham wrote:
> > Quoting Andy Shevchenko (2025-03-31 08:34:35)
> > > Convert the module to be property provider agnostic and allow
> > > it to be used on non-OF platforms.
> >
> > Looks reasonable to me.
>
> Is that going to work out of the box though ? The calls below read the
> "reg" property to get the device I2C addresses. AFAIK, ACPI handles I2C
> addresses using ACPI-specific methods.
>
> Andy, have you tested this patch on an ACPI system ?
Only compile-tested. But you are right, this is something different here
between OF and ACPI.
I can rephrase the commit message to just point out that fwnode.h shouldn't
be in the drivers and either converting to device property in an assumption
that later it can be easier to support non-OF cases, or using of.h.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-31 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 7:34 [PATCH v1 1/1] media: i2c: rdacm2x: Make use of device properties Andy Shevchenko
2025-03-31 8:16 ` Kieran Bingham
2025-03-31 12:07 ` Laurent Pinchart
2025-03-31 12:23 ` Andy Shevchenko [this message]
2025-03-31 15:34 ` Laurent Pinchart
2025-03-31 16:22 ` Andy Shevchenko
2025-03-31 16:27 ` Laurent Pinchart
2025-03-31 16:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-qJOeeHUgWCtkTv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox