Re: Re: [PATCH] ARM: Fix support for CMDLINE_EXTEND

Russell King (Oracle)
2025-03-31T15:18:21Z

On Mon, Mar 31, 2025 at 06:14:27PM +0300, Maxim Uvarov wrote:
> It will be good to have some constance here with other arches:
> ./arch/arm/kernel/atags_parse.c:#if defined(CONFIG_CMDLINE_EXTEND)
> ./arch/sh/kernel/setup.c:#ifdef CONFIG_CMDLINE_EXTEND
> ./arch/powerpc/kernel/prom_init.c: if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) || l <= 0 || p[0] == '\0')
> ./arch/loongarch/kernel/setup.c: * CONFIG_CMDLINE_EXTEND is enabled.
> ./arch/loongarch/kernel/setup.c: if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) && CONFIG_CMDLINE[0]) {
> ./arch/riscv/kernel/pi/cmdline_early.c: if
> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) ||
>
> Or drop CONFIG_CMDLINE_EXTEND completely or make arm64 work as others.

I'm not changing something that has had 14 years of being the way it's
been - people will have come to rely upon it. Changing it now is way
too late.