Re: [PATCH] phy: freescale: fsl-samsung-hdmi: return closest rate instead LUT

Adam Ford
2025-05-04T20:44:37Z

On Mon, Mar 10, 2025 at 11:12 AM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
>
> Hello Dominique,
>
> On Mon, Mar 10, 2025 at 06:48:50PM +0900, Dominique Martinet wrote:
> > [...] and I'm sure there are other improvements that could be made at
> > the edges.
>
> One thing that irritated me is the function names. `phy_clk_round_rate`
> sounds too generic. `fsl_samsung_hdmi_phy_clk_round_rate` is long, but
> I'd say would be a better match.
Uwe,

I just sent a patch to rename round_rate and set rate functions to be
more explicit. I also tried to refactor the driver as you requested
by simplifying the code, but I didn't have time to integrate my
fractional-divder code yet.

I will be traveling for most of May, so I won't be able to revisit
this again until after May 24. Hopefully the patches I submitted meet
your satisfaction, and I hope they address some of the concerns from
Dominique. I also CC'd Frieder, since he's been active with this
driver as well.

adam
>
> Best regards
> Uwe