From: "Günther Noack" <gnoack@google.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
Paul Moore <paul@paul-moore.com>,
syzbot+8bca99e91de7e060e4ea@syzkaller.appspotmail.com
Subject: Re: [PATCH v1] landlock: Remove incorrect warning
Date: Tue, 1 Apr 2025 11:51:00 +0000 [thread overview]
Message-ID: <Z-vTJPowPSqcBmmD@google.com> (raw)
In-Reply-To: <20250331104709.897062-1-mic@digikod.net>
On Mon, Mar 31, 2025 at 12:47:07PM +0200, Mickaël Salaün wrote:
> landlock_put_hierarchy() can be called when an error occurs in
> landlock_merge_ruleset() due to insufficient memory. In this case, the
> domain's audit details might not have been allocated yet, which would
> cause landlock_free_hierarchy_details() to print a warning (but still
> safely handle this case).
>
> We could keep the WARN_ON_ONCE(!hierarchy) but it's not worth it for
> this kind of function, so let's remove it entirely.
Reviewed-by: Günther Noack <gnoack@google.com>
-Günther
prev parent reply other threads:[~2025-04-01 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-30 10:15 [syzbot] [lsm?] WARNING in free_ruleset syzbot
2025-03-31 10:47 ` [PATCH v1] landlock: Remove incorrect warning Mickaël Salaün
2025-04-01 11:51 ` Günther Noack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-vTJPowPSqcBmmD@google.com \
--to=gnoack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=paul@paul-moore.com \
--cc=syzbot+8bca99e91de7e060e4ea@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox