From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Gregory Price <gourry@gourry.net>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>,
Raghavendra K T <raghavendra.kt@amd.com>,
linux-kernel@vger.kernel.org,
linux-cxl <linux-cxl@vger.kernel.org>,
Bharata B Rao <bharata@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Alistair Popple <apopple@nvidia.com>,
Bjorn Helgaas <bhelgaas@google.com>, Baoquan He <bhe@redhat.com>,
ilpo.jarvinen@linux.intel.com,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Fontenot Nathan <Nathan.Fontenot@amd.com>,
Wei Huang <wei.huang2@amd.com>
Subject: Re: [RFC PATCH] resource: Fix CXL node not populated issue
Date: Wed, 4 Dec 2024 00:07:47 +0200 [thread overview]
Message-ID: <Z0-BM5KcS9PQcycg@smile.fi.intel.com> (raw)
In-Reply-To: <CAAt7c_piFt2UY_OSzdhhr3yFfgMZPgcw2ogtAoVRjgDFGaG_8Q@mail.gmail.com>
On Tue, Dec 03, 2024 at 11:56:35AM -0800, Gregory Price wrote:
> On Tue, Dec 3, 2024, 6:09 AM Andy Shevchenko <
> andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Dec 03, 2024 at 02:26:52PM +0800, Huang, Ying wrote:
> > > Raghavendra K T <raghavendra.kt@amd.com> writes:
...
> > > > git bisect had led to below commit
> > > > Fixes: b4afe4183ec7 ("resource: fix region_intersects() vs
> > add_memory_driver_managed()")
> > >
> > > This breaks you case, sorry about that. But this also fixed a real bug
> > > too. So, it's not appropriate just to revert it blindly.
> >
> > Linus was clear about this recently. Even if it fixes a bug, regression is
> > still regression
>
> In my experience, region intersection issues often stem from bad CEDT
> entries.
Yeah, sometimes fixes may reveal the hidden issues.
> Have you dumped the ACPI tables on your system and validated the content?
I believe this is the Q to the original reporter.
> It would be a shame to revert a patch because the ACPI tables were wrong.
I agree with you and as I said in my reply "fixes are better than reverts".
I.o.w. I'm on the same page with Linus on this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-03 22:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 11:19 [RFC PATCH] resource: Fix CXL node not populated issue Raghavendra K T
2024-12-02 15:34 ` Andy Shevchenko
2024-12-03 6:01 ` Raghavendra K T
2024-12-03 6:26 ` Huang, Ying
2024-12-03 13:41 ` Andy Shevchenko
[not found] ` <CAAt7c_piFt2UY_OSzdhhr3yFfgMZPgcw2ogtAoVRjgDFGaG_8Q@mail.gmail.com>
2024-12-03 22:07 ` Andy Shevchenko [this message]
2024-12-04 2:07 ` Huang, Ying
2024-12-04 3:01 ` Andy Shevchenko
2024-12-04 4:44 ` Raghavendra K T
2024-12-05 5:45 ` Raghavendra K T
2024-12-04 3:55 ` Dan Williams
2024-12-04 4:41 ` Raghavendra K T
2024-12-06 7:50 ` Dan Williams
2024-12-06 8:28 ` Raghavendra K T
2024-12-11 4:44 ` Dan Williams
2024-12-11 6:40 ` Bharata B Rao
2024-12-11 8:38 ` Dan Williams
2024-12-11 16:47 ` Bharata B Rao
2024-12-12 1:02 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0-BM5KcS9PQcycg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Nathan.Fontenot@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=apopple@nvidia.com \
--cc=bharata@amd.com \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=gourry@gourry.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=raghavendra.kt@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=wei.huang2@amd.com \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox