Re: [GIT PULL] Staging driver changes for 6.13-rc1

[Dave Penkler <dpenkler@gmail.com>]

On Mon, Dec 02, 2024 at 06:52:28AM -0800, Guenter Roeck wrote:
> On Mon, Dec 02, 2024 at 10:50:07AM +0100, Dave Penkler wrote:
> [ ... ]
> > That is weird: the type of resource.start is resource_size_t which resolves to u32 via phys_addr_t on i386 which should be the same size as void *
> > For compile check purposes simply changing iobase type to phys_addr_t the following error message appears:
> > 
> > drivers/staging/gpib/ines/ines_gpib.c: In function 'ines_common_pci_attach':
> > drivers/staging/gpib/ines/ines_gpib.c:783:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> >   783 |         nec_priv->iobase = (void *)(pci_resource_start(ines_priv->pci_device,
> >       |                            ^
> > drivers/staging/gpib/ines/ines_gpib.c:783:26: error: assignment to 'phys_addr_t' {aka 'long long unsigned int'} from 'void *' makes integer from pointer without a cast [-Wint-conversion]
> >   783 |         nec_priv->iobase = (void *)(pci_resource_start(ines_priv->pci_device,
> >       |                          ^
> > 
> > It would seem that for some reason phys_addr_t resolves to long long unsigned int
> 
> Check out CONFIG_X86_PAE, which adds 64-bit physical address support to
> 32-bit x86 images. Pointers are still 32 bit in that mode, though.
> 
> Guenter
OK thanks. I will submit a patch to use ioremap.
-Dave