From: Vinod Koul <vkoul@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Paul Cercueil <paul@crapouillou.net>,
Nuno Sa <nuno.sa@analog.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] linux/dmaengine.h: fix a few kernel-doc warnings
Date: Mon, 2 Dec 2024 21:51:48 +0530 [thread overview]
Message-ID: <Z03enImvI+c7cZYw@vaman> (raw)
In-Reply-To: <1dcee6d5-761b-4fa2-a336-c23d3aaadcb9@infradead.org>
On 24-11-24, 22:20, Randy Dunlap wrote:
>
>
> On 11/24/24 10:15 PM, Randy Dunlap wrote:
> > The comment block for "Interleaved Transfer Request" should not begin
> > with "/**" since it is not in kernel-doc format.
> >
> > Fix doc name for enum sum_check_flags.
> >
> > Fix all (4) missing struct member warnings.
> >
> > Use "Warning:" for one "Note:" in enum dma_desc_metadata_mode since
> > scripts/kernel-doc does not allow more than one Note:
> > per function or identifier description.
> >
> > This leaves around 49 kernel-doc warnings like:
> > include/linux/dmaengine.h:43: warning: Enum value 'DMA_OUT_OF_ORDER' not described in enum 'dma_status'
> >
> > and another scripts/kernel-doc problem with it not being able to parse
> > some typedefs.
> >
> > Fixes: b14dab792dee ("DMAEngine: Define interleaved transfer request api"), Jassi Brar
>
> Oops, I left a note in the line above. I'll fix it for v2 after comments.
lgt,, I guess we can do a v2 now
>
> > Fixes: ad283ea4a3ce ("async_tx: add sum check flags")
> > Fixes: 272420214d26 ("dmaengine: Add DMA_CTRL_REUSE")
> > Fixes: f067025bc676 ("dmaengine: add support to provide error result from a DMA transation")
> > Fixes: d38a8c622a1b ("dmaengine: prepare for generic 'unmap' data")
> > Fixes: 5878853fc938 ("dmaengine: Add API function dmaengine_prep_peripheral_dma_vec()")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Jassi Brar <jaswinder.singh@linaro.org>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: Paul Cercueil <paul@crapouillou.net>
> > Cc: Nuno Sa <nuno.sa@analog.com>
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: dmaengine@vger.kernel.org
> > ---
> > include/linux/dmaengine.h | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
>
>
> --
> ~Randy
>
--
~Vinod
prev parent reply other threads:[~2024-12-02 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 6:15 [PATCH] linux/dmaengine.h: fix a few kernel-doc warnings Randy Dunlap
2024-11-25 6:20 ` Randy Dunlap
2024-12-02 16:21 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z03enImvI+c7cZYw@vaman \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=paul@crapouillou.net \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox