From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28FC91EF0AC for ; Tue, 3 Dec 2024 16:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733243758; cv=none; b=Bj9FcJGwF0XJf/PwXgspYDDqjKjK5hRu2+2DpvB/A26+JK5hz7PTiIX7H6UcsoB9Kv4XMLvxctVqE2k0XUBmv7+OM5z3oQThXXEiZ1X0k90gjLD6YkvhSViURNqWJ11UeEtTo6FA2qZqIwsEYAP0J8e+Af6/bD0T98G9cV6kU90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733243758; c=relaxed/simple; bh=dFp98OfpMWvwW3ghj5pq33xsKpu2POJ7V9Uyc2h8Ccs=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=btrYpqYLXjMxMuW0Rsqqp+XHcNtmj8ZAzVxNfQniPNJ5U7nAzlDjDIkXZPkF6r9mcRZNerPx/UwP/DPoJQ8Jbxcus+fyVIdmXT8WhFq0WEkZ/BMwSizuNf22LOQmpTmCfjVsmaLy95tB5O+n63FPhA5ifxUGngvyuL9Eu87uMFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=tpqNiy4n; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="tpqNiy4n" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-7f71f2b136eso4133713a12.1 for ; Tue, 03 Dec 2024 08:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1733243756; x=1733848556; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=eMCO3hjmaxXEHEZCxPuR/pj5UkTYrp53NHnVS+id1qE=; b=tpqNiy4n1N83HIzfzrwhGvz7EHfRKidzO+353+iAZX+6ctCLzZpTQuEcYVsBKU7lFp 8gj6YD5Vhw4Pl7MhHjpsXl9LYzm5vw29ggsJXuP3B1dY7MTa4k8ltUjfw6l+naaetFlU /OE5h0JLPzPM6AS30/iPhxGsO0EGtmgbQaQbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733243756; x=1733848556; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eMCO3hjmaxXEHEZCxPuR/pj5UkTYrp53NHnVS+id1qE=; b=V/yPM3pr6t6Ujuf5b5a0RS+swYnsvEVighXUL/b1OHTp8gw/PwobH65d/AnyQAfUxn 3oHxwIgAZ7ktOQRjN0w1Oo8mlKIEs8qGykB3lHVY5GLMJUT8qMG+tucuRo51WC8azQqX pBGfoT37UJUQm+zCCDd6NfwYaionjdm9I/h2eVaheCUADOfVFAn7FhSCcWNLqmnqku2z es3ke6QTSkUmeZCci18iJ2oX1tbC5TUUxQUjzq7PFZIbvoP5iNOTAfpcTzyGE8+cu2kI TjsqbOnvyv+HfABg+HyRIcnFhxHvyEiw1nX5PiyZsX8XIL2UHzgq4chksK3lZJr1jjkn 3ZXg== X-Forwarded-Encrypted: i=1; AJvYcCX1De46sLzQVwEdNUFJLp2CatoG93RWSFdR7hc/P+NqxYg8x4GzlDD6GYH1Ef3Z2h8TrO6vC4frhX9zfhY=@vger.kernel.org X-Gm-Message-State: AOJu0YxlzGUlv4s3vj/XtbbMR46N9aSAaZrQ5V5C+HTZDr2vAQHVLZk+ yokRVtR72T/7szHsBmVUMuKW0EXsdp/snDn8ea5hMPaunuGsZBYobdgkijPXejg= X-Gm-Gg: ASbGncvyPECDWv8+N7uxc+/guIuWWGmuYGdhWaCjY7vFJBvUKO/UfTmAw/1/kB6TyKF O8/fSrT30viW8mI4nLb/nCrGOWLsKcWJwgGCRuvX9F/HXbXybguu152VKnT0AfEjP0tplazH1tO LQoc9FHHqwqTbfI3avrKU1+PSWjdg/qJ0ClwM59c7EZ7ILdQM4qddtVvjhrqUnsrjSs+HV6S3i9 NeRY6jvbrLpNYXv4aOMdfqnBkb3WAhlyOzpIN+COouPMJgR1pC6h/wVToUWHSA9RXxwiHZaPZNI AJLfdu3rBG13DUrQ X-Google-Smtp-Source: AGHT+IFVZBDfisb7ERSwPZ6gx3N4o5KaG91v/EEN/NxN3XFwgoF7+a4ZZdAGwJeFgfqV/IJSPkMgPA== X-Received: by 2002:a05:6a21:3398:b0:1e0:c751:2723 with SMTP id adf61e73a8af0-1e1653f23cbmr4665291637.30.1733243756361; Tue, 03 Dec 2024 08:35:56 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fc9c3a2cb9sm9893644a12.74.2024.12.03.08.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 08:35:55 -0800 (PST) Date: Tue, 3 Dec 2024 08:35:53 -0800 From: Joe Damato To: Stanislav Fomichev , netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, kuba@kernel.org, mkarsten@uwaterloo.ca, "David S. Miller" , Simon Horman , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , open list Subject: Re: [PATCH net-next] selftests: net: cleanup busy_poller.c Message-ID: Mail-Followup-To: Joe Damato , Stanislav Fomichev , netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, kuba@kernel.org, mkarsten@uwaterloo.ca, "David S. Miller" , Simon Horman , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , open list References: <20241203012838.182522-1-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 03, 2024 at 08:26:11AM -0800, Joe Damato wrote: > On Mon, Dec 02, 2024 at 09:14:58PM -0800, Stanislav Fomichev wrote: > > On 12/03, Joe Damato wrote: > > > Fix various integer type conversions by using strtoull and a temporary > > > variable which is bounds checked before being casted into the > > > appropriate cfg_* variable for use by the test program. > > > > > > While here, free the strdup'd cfg string for overall hygenie. > > > > Thank you for fixing this! I also saw them this morning after a net-next > > pull and was about to post... I also see the following (LLVM=1): > > > > busy_poller.c:237:6: warning: variable 'napi_id' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > > 237 | if (napi_list->obj._present.id) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > busy_poller.c:243:38: note: uninitialized use occurs here > > 243 | netdev_napi_set_req_set_id(set_req, napi_id); > > | ^~~~~~~ > > busy_poller.c:237:2: note: remove the 'if' if its condition is always true > > 237 | if (napi_list->obj._present.id) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 238 | napi_id = napi_list->obj.id; > > | ~ > > 239 | else > > | ~~~~ > > 240 | error(1, 0, "napi ID not present?"); > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > busy_poller.c:226:18: note: initialize the variable 'napi_id' to silence this warning > > 226 | uint32_t napi_id; > > | ^ > > | = 0 > > 1 warning generated. > > > > Presumably the compiler can't connect that fact that (!preset.id) -> > > error. So maybe initialize napi_id to 0 to suppress it as well? > > Thanks for the report! Can I ask what compiler and version you are > using so that I can test before reposting? Err, sorry. Haven't had coffee yet. I see you mentioned LLVM=1 above. When I use that I also get the same error. FWIW: I'm using clang version 10.0.0-4ubuntu1 (which as far as I can tell is pretty old). I'll see if I can get a newer version just to make sure no other warnings appear.