From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CD21FAC3B for ; Tue, 3 Dec 2024 18:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733250728; cv=none; b=ALOHbzXVu994VXtIzXzuGzZddb2UiETzUQ24CCULuZRHEdj6Bxui1LfmdSLFeSetyski9QgiICqPCOz37p0mPQn8GZXCJFQ65Bcr+YDrVSPQQlUrqksUQ560v5ucR8dq98vBSczxsvxD9OLTfVJF6ELNRFQA1lD5a2Pmg3zIwxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733250728; c=relaxed/simple; bh=teJpmPTMJwM4XhRCt98E5exgGcMwwsgs/+69aF/6jTs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gQIdhrTNTbijP/z0Nmw7iVA9oDdeMbLFR76FOUwt5nsrf66MOBbNtXnz3ppgXHmq+QlI3Z4XHadWdWN6l667d0wDC9lqyO/YSLPwd97dOuEYIYw9DC7CBRBLuu1qfEPGK2ChBkvlvoG6pCAyc2BJHX+irhTMGq7uXNZpigSWFAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=exzalodJ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="exzalodJ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-434a1639637so54718595e9.1 for ; Tue, 03 Dec 2024 10:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733250725; x=1733855525; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MA0OIWYEx7lhE8KpQkBc+3xSlNCUl4o5/5suXDXfAEw=; b=exzalodJ3+4UvOvky5pv0KEAEC2BqruWTai0ibunjgHRPzg7OITLYowpyr/jAvQUdt 9i/Qc/iB3GdPbXsXmXyepfPtoCQtsogpGiv2aIwkge3wUCTCNtL1v8ZfVg5uHntPCLl4 n1cNtT2hT1ufMD4FvNUym+NQ8d0umRv/guiiHHdqumXxAtTJmpnLGft6+CCfoHLsLuon 8gHabPQANiACfh3wMa7ohAikk8/7yM+J8GwXcEAK7uBR0B7PiG4gURXSyQdwVqXkueU1 YKHMYZqOJuRdVdPz4w507PVnit0eXjBaQwiRutvfIRD36mq7sQC5BX9lQal/N5o7989V nINg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733250725; x=1733855525; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MA0OIWYEx7lhE8KpQkBc+3xSlNCUl4o5/5suXDXfAEw=; b=IHRdKh2dhfON7fGP48gVoK4LEhpPkxdkr9e9D5cqppZ65IIrGTlSguzKPQNOW+QzE0 glUczM4CnLITVbRFy5dJ3nEHDHfplP8+xOwIUS4PGS5khy7kWSGtLDOGfy79+EsBbKED 4TKRA2hSE6A+GiYw/M96uu9K2pQN/xmKDq8VeQ+8sbBwSRyEhifwd6auYLs/qohSpAyF 4wPTZAwiiEfInrUWGrqMZ0i+Ce0AGUoXKE96xVRHRoSM6Fb9XBN+p/4pmXWFcLJCxW7I ZzN23HrXVvJQPCT6wTXfD2N07+eJvti2doJiaHKYq//zr1M228wBVpVpZbf2FZc+ig/Z T5rQ== X-Forwarded-Encrypted: i=1; AJvYcCWwiCnOniDkLTWIxPtzMHGWrLQj1GuO6MjMBPIRYd2fsahpCT1zBeBFVjdSh5aIIKhIjXmBAkwA0NwQbNY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+TKeR3Qhsf+r9PsIorMulgXoOaQkLltHINXWuGhtieZt+99VN OMrxPLwwBIbBLvqHDgpssW9/6PGWERMfZBHzti2DYQtY3EvHnE53TOVyCMlJEb0= X-Gm-Gg: ASbGncsF+IIoEOxvYMM4VEQH10YN83IMW5o59x1mDTDmkTnvYid7QjRRTSo66akETQP 8LVPrXmWqgaPCsk6R4N9o10D7EQPkyPQqN8S6BWHgU1tOZESmdU2z1uPsKEkYqwKTTAdJrLKPGN YNQ6lD5FMYy2WH/nzNtHD+w/oWgYc2DFYAGlXl0BvkxC38+QzjEYdOOF3R9J8c53zO3KI3VT78f ej4jRgpsS8e8hgqlap7G+5AS8c85T81lJ3lVI/ZepMzcYDT98EZK95sycDKWw== X-Google-Smtp-Source: AGHT+IHf+LjEeT/CgO0kZ2nnAkyl6mj5vAV7M9tzUOSZ6upVeF6Bbz1t4dAO1PkPUN1PMAflp/yrXQ== X-Received: by 2002:a5d:6483:0:b0:385:df2c:91b5 with SMTP id ffacd0b85a97d-385fd378ddamr3163149f8f.0.1733250725408; Tue, 03 Dec 2024 10:32:05 -0800 (PST) Received: from linaro.org ([2a02:2454:ff21:ef80:41ad:5703:2486:8f59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ee2c7559sm7964163f8f.12.2024.12.03.10.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 10:32:05 -0800 (PST) Date: Tue, 3 Dec 2024 19:32:01 +0100 From: Stephan Gerhold To: Bartosz Golaszewski Cc: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 4/9] crypto: qce - shrink code with devres clk helpers Message-ID: References: <20241203-crypto-qce-refactor-v1-0-c5901d2dd45c@linaro.org> <20241203-crypto-qce-refactor-v1-4-c5901d2dd45c@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203-crypto-qce-refactor-v1-4-c5901d2dd45c@linaro.org> On Tue, Dec 03, 2024 at 10:19:32AM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use devm_clk_get_optional_enabled() to avoid having to enable the clocks > separately as well as putting the clocks in error path and the remove() > callback. > > Signed-off-by: Bartosz Golaszewski FWIW: Ideally, the driver shouldn't keep on the clock all the time in the first place, since this will prevent reaching deeper low power states. So while this cleanup is nice, I think it will have to be reverted again once someone fixes that. If you're working on refactoring this rarely cared for driver, is there any chance you could add some form of runtime PM while you're at it? :-) Thanks, Stephan