* [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation
@ 2024-11-30 17:02 Yu-Chun Lin
2024-12-03 0:36 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yu-Chun Lin @ 2024-11-30 17:02 UTC (permalink / raw)
To: hch, sagi, kch
Cc: linux-nvme, linux-kernel, visitorckw, jserv, Yu-Chun Lin,
kernel test robot
cocci warnings: (new ones prefixed by >>)
>> drivers/nvme/target/pr.c:831:8-15: WARNING: kzalloc should be used for data, instead of kmalloc/memset
The pattern of using 'kmalloc' followed by 'memset' is replaced with
'kzalloc', which is functionally equivalent to 'kmalloc' + 'memset',
but more efficient. 'kzalloc' automatically zeroes the allocated
memory, making it a faster and more streamlined solution.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411301434.LEckbcWx-lkp@intel.com/
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
---
build test only.
drivers/nvme/target/pr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvme/target/pr.c b/drivers/nvme/target/pr.c
index 25a02b50d9f3..90e9f5bbe581 100644
--- a/drivers/nvme/target/pr.c
+++ b/drivers/nvme/target/pr.c
@@ -828,12 +828,11 @@ static void nvmet_execute_pr_report(struct nvmet_req *req)
goto out;
}
- data = kmalloc(num_bytes, GFP_KERNEL);
+ data = kzalloc(num_bytes, GFP_KERNEL);
if (!data) {
status = NVME_SC_INTERNAL;
goto out;
}
- memset(data, 0, num_bytes);
data->gen = cpu_to_le32(atomic_read(&pr->generation));
data->ptpls = 0;
ctrl_eds = data->regctl_eds;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation
2024-11-30 17:02 [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation Yu-Chun Lin
@ 2024-12-03 0:36 ` Christoph Hellwig
2024-12-03 2:00 ` Chaitanya Kulkarni
2024-12-03 19:03 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2024-12-03 0:36 UTC (permalink / raw)
To: Yu-Chun Lin
Cc: hch, sagi, kch, linux-nvme, linux-kernel, visitorckw, jserv,
kernel test robot
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation
2024-11-30 17:02 [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation Yu-Chun Lin
2024-12-03 0:36 ` Christoph Hellwig
@ 2024-12-03 2:00 ` Chaitanya Kulkarni
2024-12-03 19:03 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2024-12-03 2:00 UTC (permalink / raw)
To: Yu-Chun Lin, hch@lst.de, sagi@grimberg.me, Chaitanya Kulkarni
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
visitorckw@gmail.com, jserv@ccns.ncku.edu.tw, kernel test robot
On 11/30/24 09:02, Yu-Chun Lin wrote:
> cocci warnings: (new ones prefixed by >>)
>>> drivers/nvme/target/pr.c:831:8-15: WARNING: kzalloc should be used for data, instead of kmalloc/memset
> The pattern of using 'kmalloc' followed by 'memset' is replaced with
> 'kzalloc', which is functionally equivalent to 'kmalloc' + 'memset',
> but more efficient. 'kzalloc' automatically zeroes the allocated
> memory, making it a faster and more streamlined solution.
>
> Reported-by: kernel test robot<lkp@intel.com>
> Closes:https://lore.kernel.org/oe-kbuild-all/202411301434.LEckbcWx-lkp@intel.com/
> Reviewed-by: Kuan-Wei Chiu<visitorckw@gmail.com>
> Signed-off-by: Yu-Chun Lin<eleanor15x@gmail.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation
2024-11-30 17:02 [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation Yu-Chun Lin
2024-12-03 0:36 ` Christoph Hellwig
2024-12-03 2:00 ` Chaitanya Kulkarni
@ 2024-12-03 19:03 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2024-12-03 19:03 UTC (permalink / raw)
To: Yu-Chun Lin
Cc: hch, sagi, kch, linux-nvme, linux-kernel, visitorckw, jserv,
kernel test robot
On Sun, Dec 01, 2024 at 01:02:58AM +0800, Yu-Chun Lin wrote:
> cocci warnings: (new ones prefixed by >>)
> >> drivers/nvme/target/pr.c:831:8-15: WARNING: kzalloc should be used for data, instead of kmalloc/memset
>
> The pattern of using 'kmalloc' followed by 'memset' is replaced with
> 'kzalloc', which is functionally equivalent to 'kmalloc' + 'memset',
> but more efficient. 'kzalloc' automatically zeroes the allocated
> memory, making it a faster and more streamlined solution.
Thanks, applied to nvme-6.13.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-03 19:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-30 17:02 [PATCH] nvmet: replace kmalloc + memset with kzalloc for data allocation Yu-Chun Lin
2024-12-03 0:36 ` Christoph Hellwig
2024-12-03 2:00 ` Chaitanya Kulkarni
2024-12-03 19:03 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox