From: Matthew Wilcox <willy@infradead.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mateusz Guzik <mjguzik@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Hao-ran Zheng <zhenghaoran@buaa.edu.cn>,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, baijiaju1990@gmail.com,
21371365@buaa.edu.cn
Subject: Re: [RFC] metadata updates vs. fetches (was Re: [PATCH v4] fs: Fix data race in inode_set_ctime_to_ts)
Date: Sun, 24 Nov 2024 22:34:50 +0000 [thread overview]
Message-ID: <Z0OqCmbGz0P7hrrA@casper.infradead.org> (raw)
In-Reply-To: <20241124222450.GB3387508@ZenIV>
On Sun, Nov 24, 2024 at 10:24:50PM +0000, Al Viro wrote:
> On Sun, Nov 24, 2024 at 02:10:30PM -0800, Linus Torvalds wrote:
> > I *do* think that we could perhaps extend (and rename) the
> > inode->i_size_seqcount to just cover all of the core inode metadata
> > stuff.
>
> That would bring ->i_size_seqcount to 64bit architectures and
> potentially extend the time it's being held quite a bit even
> on 32bit...
Could we just do:
again:
nsec = READ_ONCE(inode->nsec)
sec = READ_ONCE(inode->sec)
if (READ_ONCE(inode->nsec) != nsec)
goto again;
?
next prev parent reply other threads:[~2024-11-24 22:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 2:43 [PATCH] fs: Fix data race in inode_set_ctime_to_ts Hao-ran Zheng
2024-11-21 11:35 ` Jan Kara
2024-11-22 3:51 ` [PATCH v2] " Hao-ran Zheng
2024-11-22 11:13 ` Christian Brauner
2024-11-22 11:22 ` Jan Kara
2024-11-22 11:48 ` 郑浩然
2024-11-22 13:06 ` [PATCH v3] " Hao-ran Zheng
2024-11-23 14:01 ` Jeff Layton
2024-11-24 8:46 ` 郑浩然
2024-11-24 9:42 ` [PATCH v4] " Hao-ran Zheng
2024-11-24 17:44 ` Darrick J. Wong
2024-11-24 17:56 ` Mateusz Guzik
2024-11-24 18:34 ` Darrick J. Wong
2024-11-24 21:50 ` [RFC] metadata updates vs. fetches (was Re: [PATCH v4] fs: Fix data race in inode_set_ctime_to_ts) Al Viro
2024-11-24 22:10 ` Linus Torvalds
2024-11-24 22:24 ` Al Viro
2024-11-24 22:34 ` Matthew Wilcox [this message]
2024-11-24 22:43 ` Linus Torvalds
2024-11-24 23:53 ` Matthew Wilcox
2024-11-25 0:53 ` Linus Torvalds
2024-11-25 1:02 ` Linus Torvalds
2024-11-25 1:15 ` Matthew Wilcox
2024-11-25 1:26 ` Linus Torvalds
2024-11-24 22:40 ` Linus Torvalds
2024-11-24 23:05 ` Mateusz Guzik
2024-11-24 23:19 ` Mateusz Guzik
2024-11-24 23:41 ` Al Viro
2024-11-24 23:38 ` Al Viro
2024-11-25 12:20 ` Christian Brauner
2024-11-24 22:10 ` Dr. David Alan Gilbert
2024-11-24 22:19 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2024-11-26 6:44 郑浩然
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0OqCmbGz0P7hrrA@casper.infradead.org \
--to=willy@infradead.org \
--cc=21371365@buaa.edu.cn \
--cc=baijiaju1990@gmail.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zhenghaoran@buaa.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox