From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14F8D18D64B for ; Mon, 25 Nov 2024 08:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524883; cv=none; b=DJSd3zLuK9FJXeICF/Ang9KXS35n1Ueia8tQxEsXEYylFP0njwqgfX6bA3eczeUKY0Goa2ujpkH9G7BRXRfZMX/RBSZ61ACjufV5pkDrmcXXn9fZSf0HNANXUkimkw2gIBQUwF/DG92E+Uk+iQH+LqgXbGH5upfQuDopbgwc8UQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524883; c=relaxed/simple; bh=uZFCAWid8rhJHzelkWD3pFnre9T42ijXLP2LF1wPb9E=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nA1e4BxHEL0e78OfCrBLFkwtpKeHQiwK3tRsG+3b2Mv1FwGgsZwQdy1gwQsuDGniqhxN0xQ5FMM4/s0Gu1yAzFjVGX/vgGRXy4uxQg+tqYygxTSahwQsm3xQdo7Vh4G0GqnY99kbuZfKWNLo1aWiHWBGVRH0WKaG2wTIDp2be5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TYtW/zP3; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TYtW/zP3" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5cfcb7183deso8840629a12.0 for ; Mon, 25 Nov 2024 00:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732524879; x=1733129679; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=mBZh/dlJgKLPhdmjnm36EVhHzC98YQaW9Lth/5vAKvc=; b=TYtW/zP3oxM1vFpM4KM8y6kvAht7l8o2L3yAU4ZwzteZAKmcbfAw8/WaoqTT3dTtiC cUftivx1BsOxrK0/JqNDCiJc366IyQbjOH4EI6rY7ZiYoX0xhGT2irkgFxMdJcmyAVel c/sjwVbyA4syCPaIRvjcuuZOi6VOS9DkpMBAOnNcGvcnPFrn9zNn6z1FYBNEfhObgdnJ rzU21xHVizGo+uiDf1yW/OlhTtMQ3w39bQL9SOVSncSGPWMPfFo43Nx2Q1m1p1HYCgIK 0jqtquHIKJIzjITbwZf4Aif6uFYkC8+8Fu3RC6hb9avaZ1Q0rGptY2c+B4ggNkffJ57D J84Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732524879; x=1733129679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mBZh/dlJgKLPhdmjnm36EVhHzC98YQaW9Lth/5vAKvc=; b=gK40YNBGOEprQYoMa3FQxzZ9VECz40qX10qrq3PUd4GFQdLT8X8NzV6sBw4DlsDzc6 vUMyUX0ystoN0IBp5BN7rVYsl5MqqJTbdWnALDcDmF+k6ij9QQcGH96FieavziINHwVS BhjYmfZF1CwK4fjsjwnAOMNUPdIbnnp5oKf5eusrB46HpbaSuNjajWh5KNFwI93yk2SD NbfvSf//0Ntty93+u8mxCrrdbcverBvc8Ibe6KmMCe/twjYPsccJ3yVDF+u3UylUrTMG EWlkozPAoaH7UXOL9E65j7uZXjKTUyUsxxCa+WCc04B8Bd+InYnkIJnWOeYRbAEAkgll YZFw== X-Forwarded-Encrypted: i=1; AJvYcCWcSoZfDIDGKUNVjl9W8RhZhpShAZSMClw6LKTIfc/o1JyKckkS9ePdH8zQcfJj4NOC0OeivX0VtLKiYRU=@vger.kernel.org X-Gm-Message-State: AOJu0YywqudbFcYhcjBVAgH1EKF88KNuEnP5TBI+C+pxIKDwhs2qaTGr WU4HchPIZzXdNqUK+50EzlEMc8tC0q6dGPwUgGt+mc902ZYENdDWz3YaU8ywN4o= X-Gm-Gg: ASbGncsittVHth4QNWPs6L9FbuKbdmSnUkpi1CoCHG8019cM5XXTZgsGMuf/ppM3HM6 c5A9epiKl43EuaQHQr0oMO6Omom8z9A1l7oasJLfTY4Jdrydu+YBg8MZ5SO5+jLSUiMSSzRvxIL Nu5fom23e8kXw69hnUFQZcG8iLWCm6JXmNWRoZZG0GR0pEDjVXGGiJ51HQK2y9uEahwyDbOiy0z +pVmeSv1jBePHvIJ1KKYE2+ujGjDk54x3L5nx7pgbrILK7VDnBmJFS9a7+nzjwzNgcmwK80Igm1 uoVT36wQVPwJPMDV+ulL X-Google-Smtp-Source: AGHT+IFNCFEK1ia8R/Vdi4LB9FLJuTXnKmbw4fkVMzsCxQu2qYrzuZQkQ2EAs+H3uMAiTz2NmcDbIA== X-Received: by 2002:a17:907:60ce:b0:aa4:e53f:5fbe with SMTP id a640c23a62f3a-aa509a1c2f9mr1339686366b.19.1732524879322; Mon, 25 Nov 2024 00:54:39 -0800 (PST) Received: from localhost (host-79-49-220-127.retail.telecomitalia.it. [79.49.220.127]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa51759732asm406733166b.14.2024.11.25.00.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 00:54:38 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 25 Nov 2024 09:55:11 +0100 To: Andrew Lunn Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v4 09/10] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5 Message-ID: References: <8deccbd7ab8915957342a097410473445987b044.1732444746.git.andrea.porta@suse.com> <9abb376c-3399-4c2c-8e7c-cea1184ea370@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9abb376c-3399-4c2c-8e7c-cea1184ea370@lunn.ch> Hi Andrew, On 20:41 Sun 24 Nov , Andrew Lunn wrote: > On Sun, Nov 24, 2024 at 11:51:46AM +0100, Andrea della Porta wrote: > > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz. > > Add clk_rp1_xosc node to provide that. > > I'm wondering if this is the correct place for this clock. From your > description, the bcm2712 itself does not provide the clock. There is a > crystal on the board. So the board provides the clock. What happens > when the RP1 is used on other boards? Also, does the RP1 need an > actual crystal, or can you feed it a clock? Often such inputs are > flexible, you can connect a crystal across two pins, or you can feed a > clock into one pin. AFAICT the only choice would be a crystal (I'll try to confirm that with Rpi folksi, just to be sure). In fact, I've expressed your same concern in the dicsussion that followed previous patchset revisions, and it seems that the preferred way is still to stick to the current hw: since the crystal is on the same board as bcm2712, it should not be described on the overaly. I think you're right though on moving the clock definition to the board dts. I'm still planning to define the clock in the rp1 overlay if any new PCI card will contain it in the future: after all it will not cause any clash with the clock defined in the board dts, which could be then removed gradually. Many thanks, Andrea > > If a crystal is the only choice, i would probably have it part of the > RP1 overlay. If a clock can be used, i would make it a board property. > > Andrew