Re: [PATCH V4 RESEND 2/3] dt-bindings: rtc: Add support for ATCRTC100 RTC

[CL Wang <cl634@andestech.com>]

Hi Krzysztof,

Thank you for your feedback.
Regarding your comments:

1. I will base the patch series (v4) on the rtc-next branch from
   git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git to
   generate the new patch series (v5). If this branch is not the correct
   base for the patch set, please let me know.

2. Concerning your previous feedback, I have already addressed the points
   and mentioned the changes in the changelogs of each patch.

3. I will use scripts/get_maintainer.pl to obtain the proper list of
   recipients and ensure that all necessary individuals and mailing lists
   (including the Devicetree list) are included in the next submission.
   I will also evaluate the use of b4 as suggested.

Thank you for your patience. I will submit the updated patch series soon.

Best regards,
CL Wang



On Tue, Nov 19, 2024 at 08:44:09AM +0100, Krzysztof Kozlowski wrote:
> [EXTERNAL MAIL]
> 
> On 14/11/2024 15:00, CL Wang wrote:
> > Document Device Tree bindings for the Andes ATCRTC100 Real-Time Clock.
> >
> > Signed-off-by: CL Wang <cl634@andestech.com>
> > ---
> 
> Never tested.
> 
> You keep ignoring feedback - do not respond, do not address, do not fix.
> 
> NAK.
> 
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
> 
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
> 
> Best regards,
> Krzysztof
>