From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E134567D for ; Mon, 25 Nov 2024 13:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.248.80.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732540219; cv=none; b=BO4339JlpGsb5Tm6LTT0jBK+94a22kaVYhb6PyWHB9ZJv6WsnEub8Wan1cVDfkgG/sKbdsGIj3x//pkHfQW7doeAosB3OhMJWooUwmGm0bvT/e5kX0UJFjtYjwC/TXgd2nRx8AgjV93KBZbHyBRQi29C0+AhJiZ7xCGptKMjwQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732540219; c=relaxed/simple; bh=13F4cEGHqjK2B5MOk8zbRLecZrSMzPSQPAXtI1E1kiU=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aOv40yKyhP7OWb5A7AsZhb4DeoNZbkCjoxahMyNIjK+6YRL5/rtAqNHJDaRWsjnY9v58jOb2HwezIoKvuFf4H/hOEGtZ1YQHxm9cmxYIYnVlit95gyDckVCmG7K9+UNU/jsLDkaj2XdiqzDcZcr84gX3aUZCERTehQmQiVsRK8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=andestech.com; spf=pass smtp.mailfrom=andestech.com; arc=none smtp.client-ip=60.248.80.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=andestech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=andestech.com Received: from Atcsqr.andestech.com (localhost [127.0.0.2] (may be forged)) by Atcsqr.andestech.com with ESMTP id 4APD5pUW036185 for ; Mon, 25 Nov 2024 21:05:51 +0800 (+08) (envelope-from cl634@andestech.com) Received: from mail.andestech.com (ATCPCS34.andestech.com [10.0.1.134]) by Atcsqr.andestech.com with ESMTPS id 4APD5Pco036124 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Mon, 25 Nov 2024 21:05:25 +0800 (+08) (envelope-from cl634@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS34.andestech.com (10.0.1.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 25 Nov 2024 21:05:25 +0800 Date: Mon, 25 Nov 2024 21:05:19 +0800 From: CL Wang To: Krzysztof Kozlowski , CC: , , , , , Subject: Re: [PATCH V4 RESEND 2/3] dt-bindings: rtc: Add support for ATCRTC100 RTC Message-ID: References: <20241114140023.3534980-1-cl634@andestech.com> <20241114140023.3534980-3-cl634@andestech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) X-ClientProxiedBy: ATCPCS33.andestech.com (10.0.1.100) To ATCPCS34.andestech.com (10.0.1.134) X-DNSRBL: X-SPAM-SOURCE-CHECK: pass X-MAIL:Atcsqr.andestech.com 4APD5pUW036185 Hi Krzysztof, Thank you for your feedback. Regarding your comments: 1. I will base the patch series (v4) on the rtc-next branch from git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git to generate the new patch series (v5). If this branch is not the correct base for the patch set, please let me know. 2. Concerning your previous feedback, I have already addressed the points and mentioned the changes in the changelogs of each patch. 3. I will use scripts/get_maintainer.pl to obtain the proper list of recipients and ensure that all necessary individuals and mailing lists (including the Devicetree list) are included in the next submission. I will also evaluate the use of b4 as suggested. Thank you for your patience. I will submit the updated patch series soon. Best regards, CL Wang On Tue, Nov 19, 2024 at 08:44:09AM +0100, Krzysztof Kozlowski wrote: > [EXTERNAL MAIL] > > On 14/11/2024 15:00, CL Wang wrote: > > Document Device Tree bindings for the Andes ATCRTC100 Real-Time Clock. > > > > Signed-off-by: CL Wang > > --- > > Never tested. > > You keep ignoring feedback - do not respond, do not address, do not fix. > > NAK. > >
> Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > > Please kindly resend and include all necessary To/Cc entries. >
> > Best regards, > Krzysztof >