From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 925CE196C9B; Mon, 25 Nov 2024 10:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732531851; cv=none; b=kuGFQtPLLH7hCIJGOB4GkDRfrEEdcmvZ6Fkl+j6z8NgQqRl2bGtuwgD7HHj3TXS4JxpxGRtFwc2Rf1DIgMxM8vh0GdfEmcCtNwTiTpvSuKwZK1FEGUmsgWbyG3ue2kVS5hqyvjSzkxSuGVkSwHpMOYilkujgrxnHJfUbvgJXaUU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732531851; c=relaxed/simple; bh=Wbhswxh37Wsna+ix6qPk9ORg48ErC/7MoQ3F/8voSKY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bt/KeZI+hV8RBvbfhw/yT0uvG8CXdpi53evuLzl6XARGol7Drd/p+XzGYGoTzWN2ZJBdN3FO226/IBGa6yAOvGaSqDeHSQuENPxLjFlZ+9+y/H4vohGZjsTm9IYOvcvbhLFDiJNZfDdqbynjudG61KGsH9UuXf0iXBEAyM5AIRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LtU6m7yF; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LtU6m7yF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732531850; x=1764067850; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Wbhswxh37Wsna+ix6qPk9ORg48ErC/7MoQ3F/8voSKY=; b=LtU6m7yFiCUM/0qe3iYS0EqZwR19PFOqkoy2UaNUGB5sfHp1g2eu0t6/ jZ+FhfwJkeWGaDucd64O+T4sK7r6uK6VbgcdWTinEMk13R/ofXkw8zcnn btMu7ePRNlszVOH5481RF+VwIe5JOGzLchZUhN3kV6k+Iz9T5TcGfrSTn /Gz41Hwnr9BgEcaKMcDJ39I2JJTtSCRXKoLmMtS84jeTIvpoZCq6RIXfc MZp5c7YOAyqkydNiyPvKcn0fg8hMMEwxhM/R6rBysUAMSe4WHRJuOInki f7V/F/pb1hNaFqcr+BIPMKzjcLRXez54+LtvXKBxDFlvdvN5TVzMkF50E g==; X-CSE-ConnectionGUID: oKwSd+wZQ2W7FnfMMXQx1g== X-CSE-MsgGUID: DKd2mCeSSXidgzx5O26ZNA== X-IronPort-AV: E=McAfee;i="6700,10204,11266"; a="32881419" X-IronPort-AV: E=Sophos;i="6.12,182,1728975600"; d="scan'208";a="32881419" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2024 02:50:49 -0800 X-CSE-ConnectionGUID: eu7W6qbbRPiqV/jKpZ1QQw== X-CSE-MsgGUID: 2jMbpPspRtiqi5Jn2t9yHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,182,1728975600"; d="scan'208";a="91185077" Received: from smile.fi.intel.com ([10.237.72.154]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2024 02:50:45 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tFWfy-00000000ikZ-0tV6; Mon, 25 Nov 2024 12:50:42 +0200 Date: Mon, 25 Nov 2024 12:50:41 +0200 From: Andy Shevchenko To: Ingo Molnar Cc: Randy Dunlap , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Jonathan Corbet , Cloud Hsu , Chris Koch Subject: Re: [PATCH v1 1/1] x86/Documentation: Update algo in init_size description of boot protocol Message-ID: References: <20241125083136.1540424-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Nov 25, 2024 at 12:46:25PM +0200, Andy Shevchenko wrote: > On Mon, Nov 25, 2024 at 09:45:36AM +0100, Ingo Molnar wrote: > > * Randy Dunlap wrote: > > > On 11/25/24 12:31 AM, Andy Shevchenko wrote: ... > > > > - if (relocatable_kernel) > > > > - runtime_start = align_up(load_address, kernel_alignment) > > > > - else > > > > - runtime_start = pref_address > > > > + if ( relocatable_kernel ) { > > > > + if ( load_address < pref_address ) > > > > > > What's up with the extra spaces around ( and ) ... and inconsistent with > > > the lines below? > > I can remove them. This file has a lot of inconsistencies it seems... > > > Also, even pseudocode should follow the kernel's coding style and use > > tabs in particular - which it already does in (some...) other places of > > this document, such as the 'Sample Boot Configuration' chapter. > > The problem is that reStructuredText syntax requires that indentation. > I may follow the rules after the rST requirements, though. v2 has just been sent: https://lore.kernel.org/r/20241125105005.1616154-1-andriy.shevchenko@linux.intel.com -- With Best Regards, Andy Shevchenko