From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C486B155391 for ; Fri, 29 Nov 2024 17:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732900285; cv=none; b=RYq9HTwNuYrIqRvjDiYE/druOvMAKqpvwc+mN2aIWXcbGqvoJTf/gyxrvKO1S4cF3aOpvI82Xa6ZGCqxvG7vOmHbMS5bWHkjvvpBn6g+K0JlB13fnULt3h0HZWkaTD7fkPQ8te9tdNepYHHZjlwoHutHHVqE4BTm6Fvd/dESV/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732900285; c=relaxed/simple; bh=u4VeqDNvTWRAhnRMPvx5ZxHgDaIe1hpfxIJoqfWrVgE=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cnQGshmNccKuX8V3SoQXakPV3+tJZN2yzuHEtdS7qjqyoHYcPXf3ggz0iP8THDsxTJwNACG28HMY5nRry+IFW7aGDOlRuWBbrYFAOGK4Maw652TumXvWLrIfsQDoRGlX8MyR6IxGCaDm2cIzJE8k6S3WBwel6NLyZ90Zn8PEVkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bDOwkwrp; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bDOwkwrp" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-53df80eeeedso2134694e87.2 for ; Fri, 29 Nov 2024 09:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732900281; x=1733505081; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=wKStJ4JMYm6/f7jAdkMonmjOHy/XStYH3AHNh9QPw+k=; b=bDOwkwrp57+hdJuQM2yuTXFuR2uJQz4KquU51t8PIHqO8eQiDyD9aQNlzcorNorPaT xp7YOLadRHiHqNeLg9IJY6J/ulFR/j/syM1NdPODXmEbzVOl5mUR/WOlAKf2q/W7pRWF OVISodhH2VoKdzyWp6LX1fXe+h47Uvf/jzI/K4qJMK0C/xvuS5ytvS7xf5oYa3VTLyd7 VWtiSLzoTH2KjPpjC534rVGaPgyoky1fRIlQrXwp05orw95J08DpqUP7G6xtWuVpeMBw wDC8XOyxR1Qfs1jSuK0KTWCb5rsWjIdgrxuwVXnYBHN2hXoRrC0USPiYqn3iDJLpFYf4 VHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732900281; x=1733505081; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wKStJ4JMYm6/f7jAdkMonmjOHy/XStYH3AHNh9QPw+k=; b=CUzPTUb0Bba8dCClJFadIHEPCb5e3UzSdlrxmTZjtD0+2hEEpvUygyZSFjSdE1wuGQ JGg1v0cIPv6SepWW8CJ6aj3Myz6yHsrQxmyatxH3KubTtm/aJya5x6RS9ZZTpNnWfztV To65szmDpKDRY5w2p0xBZyCDeacFjOyAlDeg5sBbrD1uHalAO17BbtPjYWDqV9X+wirl HBgyg8PlifmUneiNEs2p5O7aFS2pCFJXcNnEqtczi7Ck8PGjKWKkOoJKkHn0Xp0jc28b mPcYuPt97f93ux8YeYa5zUkyvRHHFyG4pHHSAu3KphdHIvcJUWgx18ZMcMSjV/8RYuSW 8iqw== X-Forwarded-Encrypted: i=1; AJvYcCXGIhibmpmRXZnZLIPeXlV3UR0Hl4vkLkTnqkHn9SiFvbqPW9SQYx/r92NvZZejcZ6S0kczko/wcJ+THHA=@vger.kernel.org X-Gm-Message-State: AOJu0YxpSEU1hE1klkSwDqr7vrE9xriAX1muCt7r+3Kui9DS0xynJmjX ReGwAIzT5ZBn8IhzSEZZa9L5itWyY/CmATJtzfjieZIIxLFoMRkOoSJf9PoES/k= X-Gm-Gg: ASbGncvH5DUdPyTfTU5mwdnEbOkNHSIMHFgpRQJpFfjS2DX3LLUvtB+FFKkdXmBZZao dPDCOqI/ARI7l6CT4ePzikCZZl32SskcuvZbs5qiuV5jZprVUgRraLd/K/WxOXbAYMz96y2l1rP Qurthl0TRhoIiczfrlYS5xfoqzjZzhUHRfbjI5+c191aUSSNkgExDEqxVXpBIK7ivgvg1di1LgQ 9GOrp26ufiV22b8QjXDIfu+g94n3dlz2c0pJtIPTbDqp8ybpqykSlel7ICF6hLnhRj0fZGh7kj+ XsAcQ1O7rVLnI+8xGtBD X-Google-Smtp-Source: AGHT+IHZ3oTCh7gVSsmHhrZ3fiOp7cXkhyrNMHuydkCIk2tz2qxDfVIno+QP7oK2bTxacMEqt16MJg== X-Received: by 2002:a05:6512:39d2:b0:53d:ec9a:138f with SMTP id 2adb3069b0e04-53df0112687mr8431697e87.57.1732900280754; Fri, 29 Nov 2024 09:11:20 -0800 (PST) Received: from localhost (host-79-49-220-127.retail.telecomitalia.it. [79.49.220.127]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5998e63a2sm192130166b.113.2024.11.29.09.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 09:11:20 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 29 Nov 2024 18:11:53 +0100 To: Krzysztof Kozlowski Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v4 02/10] dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings Message-ID: References: <9b83c5ee8345e4fe26e942f343305fdddc01c59f.1732444746.git.andrea.porta@suse.com> <4ufubysv62v7aq53qfzxmup5agmqypdvemd24vm6eentph46qq@3kveluud3zd3> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ufubysv62v7aq53qfzxmup5agmqypdvemd24vm6eentph46qq@3kveluud3zd3> Hi Krzysztof, On 08:55 Wed 27 Nov , Krzysztof Kozlowski wrote: > On Sun, Nov 24, 2024 at 11:51:39AM +0100, Andrea della Porta wrote: > > + '#interrupt-cells': > > + description: > > + Specifies the Bank number [0, 1, 2] and Flags as defined in > > + include/dt-bindings/interrupt-controller/irq.h. > > + const: 2 > > + > > + interrupt-controller: true > > + > > +patternProperties: > > + "-state$": > > + oneOf: > > + - $ref: "#/$defs/raspberrypi-rp1-state" > > + - patternProperties: > > + "-pins$": > > + $ref: "#/$defs/raspberrypi-rp1-state" > > + additionalProperties: false > > + > > +$defs: > > + raspberrypi-rp1-state: > > + allOf: > > + - $ref: pincfg-node.yaml# > > + - $ref: pinmux-node.yaml# > > + > > + description: > > + Pin controller client devices use pin configuration subnodes (children > > + and grandchildren) for desired pin configuration. > > + Client device subnodes use below standard properties. > > + > > + properties: > > + pins: > > + description: > > + List of gpio pins affected by the properties specified in this > > + subnode. > > + items: > > + pattern: "^gpio([0-9]|[1-5][0-9])$" > > You have 54 GPIOs, so up to 53. Ack. > > Use also consistent quotes, either ' or ". Ack. > > Reviewed-by: Krzysztof Kozlowski Many thanks, Andrea > > Best regards, > Krzysztof >