From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB2F2500CE; Wed, 4 Dec 2024 12:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733316443; cv=none; b=tYGSsCZt4dv9JIXzeFBVDLqeaSp1e1+IH6POQrIxEkHmZAyI9b0+omethPz1Wu93DOxCPQW6WCHss76DjdpKIycsy0IwRyxA8FDl8dy6pqTFIRMrTsLcmawjLv2fKjXHfE/0YfqG6OomWe8ST9b8/egxPS9rqFUSE2K5DPZ09CE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733316443; c=relaxed/simple; bh=d4jhyyKwOpDC7EBPZIjD1O4xNyxg8HfvCdqe4g79zlg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nPwabGivIQGWwZwRkbi4wBLn6EHPhLXeZQ/YTb9E9ScvTq4CBJgR8vRnw1UC2oqG29VQRU/B8QiOVIqE1SxaYF4xGAe567ZmQkMlRA4d0pisPzmNUgIWN8MVQ4ggeEjKuuaRH8ZMtRXjtNcP6bR2EZkL9gZ3iSSSU8oCO+Y53d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F6THXQOc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F6THXQOc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50CF7C4CED1; Wed, 4 Dec 2024 12:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733316442; bh=d4jhyyKwOpDC7EBPZIjD1O4xNyxg8HfvCdqe4g79zlg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F6THXQOc42q+Fv4axUQcVqJvS38+Flfr7RGKcYYTh94VsAjgIyEl6OT4b0BLA9QPR KNY1hJj38fo4NirTp6hu8YVAjqrG3Vr0rbTaK+XrIg+yhd9XNP0PyGaUpoHui0vg4B mk/ZzwpTHpk/2cFuAeAUwAoMo330KL5xRQq6OvTOzgjsWEIy5i82rHcL4o7QfGe1E/ an3j6ndeSvNn2xdn0BUGBPAI9KmBAdcbvQsjFPgCFVxMhtdoiY4pMiZvybI9VslJz9 /OX7FI5Ym2rHAJ1mBAeXAIJId4uHxOOv0kbUIo7qJbtvxaVQ2AR9FYJhmM2dKsT7Hk nUSjw5pyxzpMw== Date: Wed, 4 Dec 2024 18:17:19 +0530 From: Vinod Koul To: Peng Fan Cc: Frank Li , "Peng Fan (OSS)" , "open list:FREESCALE eDMA DRIVER" , "open list:FREESCALE eDMA DRIVER" , open list Subject: Re: [PATCH V3 2/2] dmaengine: fsl-edma: free irq correctly in remove path Message-ID: References: <20241115105629.748390-1-peng.fan@oss.nxp.com> <20241115105629.748390-2-peng.fan@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 17-11-24, 11:07, Peng Fan wrote: > > Subject: Re: [PATCH V3 2/2] dmaengine: fsl-edma: free irq correctly in > > remove path > > > > On Fri, Nov 15, 2024 at 06:56:29PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > To i.MX9, there is no valid fsl_edma->txirq/errirq, so add a check in > > > fsl_edma_irq_exit to avoid issues. Otherwise there will be kernel > > dump: > > > > Nik: > > > > Add fsl_edma->txirq/errirq check to avoid below warning because no > > errirq at i.MX9 platform. > > > > Reviewed-by: Frank Li > > Thanks, since this is minor commit update. Not sure Vinok could help > to update, or need me to update and send v4. Not sure about Vinok :-) but I would prefer an updated patch -- ~Vinod