From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 734837DA82 for ; Thu, 5 Dec 2024 01:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.27.42.2 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733362940; cv=none; b=JzF8enmfFyeGecsJb2Qjwjhads2EZGte6T554GjIjKp1VKEI66hvz4ywHU4Dw9uA8h0kLabnthFeqKE1Bq7ECPpgvM4tAnueOBEulgxIvXhu9udb+Zsxts1OC6d3RFICyrjDS7dB6sjvtbKEyAtv6RjPy8nTRxevxNwowu6wAjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733362940; c=relaxed/simple; bh=0BURu8DvwFOVPGca6YN7y1NRJgZQgXvPSCN4SHA3hnE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZiqKa5ObyH6PNrcau+5ylB0yiPotcx1uXHAIQUK+qlmxKr/XR6PkzAtFhmfn5EtMfhEk1G7A2tf14WsRwezAaa6pBs1zT4W6bn7W2WRKxXoqYjX1A4p9ImXMuKAFr0p+Fv/grH3kZzgsuVPz+XcEdq461WihRm+GBhm6lTDkGjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=morinfr.org; spf=pass smtp.mailfrom=morinfr.org; dkim=pass (1024-bit key) header.d=morinfr.org header.i=@morinfr.org header.b=jNyoix/H; arc=none smtp.client-ip=212.27.42.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=morinfr.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=morinfr.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=morinfr.org header.i=@morinfr.org header.b="jNyoix/H" Received: from bender.morinfr.org (unknown [82.66.66.112]) by smtp2-g21.free.fr (Postfix) with ESMTPS id D44BB2003BE; Thu, 5 Dec 2024 02:42:07 +0100 (CET) Authentication-Results: smtp2-g21.free.fr; dkim=pass (1024-bit key; unprotected) header.d=morinfr.org header.i=@morinfr.org header.a=rsa-sha256 header.s=20170427 header.b=jNyoix/H; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=morinfr.org ; s=20170427; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eDKcusopXquKmHVKHd5VSYJMro9KedZVGC8QmPsjNLU=; b=jNyoix/H9aypJ6ZtgZ8JTjafWR n4d5Rd9Un3IbPtwBry1m5IxJMEUUTE2PrkxecTvkqErekdnThFkyqQDc7DDEv8HuXPRxxbbyyvlHF vbl9mFHGv50mqCQ5OMvjmGX2HIQ2P0LgH1BayeMAY6NsN9QSJBTOzcKrVFXVK3g9gH2w=; Received: from guillaum by bender.morinfr.org with local (Exim 4.96) (envelope-from ) id 1tJ0sZ-001Hrx-09; Thu, 05 Dec 2024 02:42:07 +0100 Date: Thu, 5 Dec 2024 02:42:06 +0100 From: Guillaume Morin To: David Hildenbrand Cc: Guillaume Morin , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, Muchun Song , Andrew Morton , Peter Xu , David Hildenbrand , Eric Hagberg Subject: Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE Message-ID: References: <202412050840.umPPa7cK-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202412050840.umPPa7cK-lkp@intel.com> On 05 Dec 8:39, kernel test robot wrote: > All errors (new ones prefixed by >>): > > mm/gup.c: In function 'can_follow_write_pud': > >> mm/gup.c:665:48: error: implicit declaration of function 'pud_soft_dirty'; did you mean 'pmd_soft_dirty'? [-Werror=implicit-function-declaration] > 665 | return !vma_soft_dirty_enabled(vma) || pud_soft_dirty(pud); > | ^~~~~~~~~~~~~~ > | pmd_soft_dirty > cc1: some warnings being treated as errors David, how do you recommend I deal with this? There is no prototype for pud_soft_dirty() in include/linux/pgtable.h if CONFIG_HAVE_ARCH_SOFT_DIRTY is not set. Should I just add one? -- Guillaume Morin