From: "Luck, Tony" <tony.luck@intel.com>
To: Kyle Meyer <kyle.meyer@hpe.com>
Cc: bp@alien8.de, james.morse@arm.com, mchehab@kernel.org,
rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/{i10nm,skx,skx_common}: Support multiple clumps
Date: Thu, 5 Dec 2024 15:57:55 -0800 [thread overview]
Message-ID: <Z1I-A0Rhc8AHhvtw@agluck-desk3> (raw)
In-Reply-To: <Z1Iuk-_VdmZibOes@agluck-desk3>
> +int skx_get_src_id(struct skx_dev *d, int off, u8 *id)
> +{
> +#ifdef CONFIG_NUMA
> + return skx_get_pkg_id(d, id);
> +#else
> + u32 reg;
> +
> + if (pci_read_config_dword(d->util_all, off, ®)) {
> + skx_printk(KERN_ERR, "Failed to read src id\n");
> + return -ENODEV;
> + }
> +
> + *id = GET_BITFIELD(reg, 12, 14);
> + return 0;
> +#endif
Doh ... I alwasy forget about IS_ENABLED(). This can be written:
int skx_get_src_id(struct skx_dev *d, int off, u8 *id)
{
u32 reg;
if (IS_ENABLED(CONFIG_NUMA))
return skx_get_pkg_id(d, id);
if (pci_read_config_dword(d->util_all, off, ®)) {
skx_printk(KERN_ERR, "Failed to read src id\n");
return -ENODEV;
}
*id = GET_BITFIELD(reg, 12, 14);
return 0;
}
-Tony
next prev parent reply other threads:[~2024-12-05 23:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 16:59 [PATCH] EDAC/{i10nm,skx,skx_common}: Support multiple clumps Kyle Meyer
2024-12-05 19:13 ` Luck, Tony
2024-12-05 20:05 ` Kyle Meyer
2024-12-05 22:52 ` Luck, Tony
2024-12-05 23:57 ` Luck, Tony [this message]
2024-12-06 0:57 ` Kyle Meyer
2024-12-06 1:26 ` Zhuo, Qiuxu
2024-12-06 2:33 ` Kyle Meyer
2024-12-06 21:24 ` Luck, Tony
2024-12-06 22:09 ` Luck, Tony
2024-12-10 16:37 ` Bjorn Helgaas
2024-12-10 17:50 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1I-A0Rhc8AHhvtw@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kyle.meyer@hpe.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox