From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40B021B4122 for ; Fri, 6 Dec 2024 08:56:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733475410; cv=none; b=aNd0YWcJEs4yGBPP3OVhy3KZG0SgAnJq2VYcqW8IwX04qcp1kBLtFnNRvyGXvX6XJgFefkJz8WqFFB9RjhmwwrZuhBFULCy+4EwrSgp5JC2kalziFjV3LSuTtqWAZ/n6yzIb46LSHmlQS3XA9bmu5sRrLfOpNB34UgzQLpGgqkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733475410; c=relaxed/simple; bh=DtaruFWH6LWbTsVJRfIi7OaQAHdaqNRcHsBtbIlr3sQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gq7w3FzIzoWjnK2oAqUQKccq9oA+OUyxMXn2S3AeJnFp0hbqKgd7aOMuWIeEFD+2wqI46LU5+AeadY0A4cE4XoQNXjNbj+/pH2AOzmOUY6OF11psrhJ8kuPpU/SnpIlpKrwfkPpO9SyK/6TxrL00dcBLqo+eCX3Qe2xe1FmSR04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJU8e-0005HM-Hy; Fri, 06 Dec 2024 09:56:40 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tJU8d-001y5P-08; Fri, 06 Dec 2024 09:56:39 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tJU8d-000kIi-2G; Fri, 06 Dec 2024 09:56:39 +0100 Date: Fri, 6 Dec 2024 09:56:39 +0100 From: Oleksij Rempel To: Simon Horman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , Andrew Lunn , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, Phil Elwell Subject: Re: [PATCH net-next v1 02/21] net: usb: lan78xx: Remove KSZ9031 PHY fixup Message-ID: References: <20241203072154.2440034-1-o.rempel@pengutronix.de> <20241203072154.2440034-3-o.rempel@pengutronix.de> <20241205171203.GE2581@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241205171203.GE2581@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi Simon, On Thu, Dec 05, 2024 at 05:12:03PM +0000, Simon Horman wrote: > > - dev->interface = PHY_INTERFACE_MODE_RGMII; > > - /* external PHY fixup for KSZ9031RNX */ > > - ret = phy_register_fixup_for_uid(PHY_KSZ9031RNX, 0xfffffff0, > > - ksz9031rnx_fixup); > > - if (ret < 0) { > > - netdev_err(dev->net, "Failed to register fixup for PHY_KSZ9031RNX\n"); > > - return NULL; > > - } > > + dev->interface = PHY_INTERFACE_MODE_RGMII_ID; > > + /* The PHY driver is responsible to configure proper RGMII > > + * interface delays. Disable RGMII delays on MAC side. > > + */ > > + lan78xx_write_reg(dev, MAC_RGMII_ID, 0); > > > > phydev->is_internal = false; > > } > > nit: With this change ret is now set but otherwise unused in this function. > > I would suggest a new patch, prior to this one, that drops the > other places where it is set. They seem to have no effect. > And then remove ret from this function in this patch. > There is a patch in this patch stack which will address it too. There is just limit to amount of patches I can upstream per one round. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |