From: Christoph Hellwig <hch@infradead.org>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
Ritesh Harjani <ritesh.list@gmail.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrey Albershteyn <aalbersh@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH 1/3] include/linux.h: use linux/magic.h to get XFS_SUPER_MAGIC
Date: Mon, 16 Dec 2024 00:28:00 -0800 [thread overview]
Message-ID: <Z1_kkCNX9dL0hwPf@infradead.org> (raw)
In-Reply-To: <713c4e61358b95bbdf95daca094abc73a230e52f.1734253505.git.ojaswin@linux.ibm.com>
On Sun, Dec 15, 2024 at 02:47:15PM +0530, Ojaswin Mujoo wrote:
> - return (statfsbuf.f_type == 0x58465342); /* XFSB */
> + return (statfsbuf.f_type == XFS_SUPER_MAGIC);
Might be worth dropping the superfluous braces here while you're at it.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-12-16 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 9:17 [PATCH 0/3] xfs_io: enable extsize and stat -v support for ext4 Ojaswin Mujoo
2024-12-15 9:17 ` [PATCH 1/3] include/linux.h: use linux/magic.h to get XFS_SUPER_MAGIC Ojaswin Mujoo
2024-12-16 8:28 ` Christoph Hellwig [this message]
2024-12-17 5:39 ` Ojaswin Mujoo
2024-12-15 9:17 ` [PATCH 2/3] xfs_io: allow foreign FSes to show FS_IOC_FSGETXATTR details Ojaswin Mujoo
2024-12-15 9:17 ` [PATCH 3/3] xfs_io: add extsize command support Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1_kkCNX9dL0hwPf@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox